Skip to content

fix: autoHeight should add preHeader height when enabled, fixes #1122 #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ghiscoding merged 1 commit into from
May 8, 2025
Merged

fix: autoHeight should add preHeader height when enabled, fixes #1122 #1123

ghiscoding merged 1 commit into from
May 8, 2025
+134 −48

Conversation

@ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented May 8, 2025 •
edited
Loading

fixes #1122

  • when preHeader is enabled, it should be added to the calculation of the grid container auto-height, this wasn't the case before and the frozen scroll ended up being shown in the hidden section making it completely unusable

image

@ghiscoding ghiscoding mentioned this pull request May 8, 2025
Merged
@ghiscoding ghiscoding merged commit c8f6c27 into master May 8, 2025
2 checks passed
@ghiscoding ghiscoding deleted the bugfix/auto-height-with-preheader branch May 8, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autoheight ignores pre header panel height if when using frozen columns

2 participants

@ghiscoding