-
Notifications
You must be signed in to change notification settings - Fork 434
feat: add new autoEditByKeypress to open editor by typing a char
#1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks great. I ran in to some issue with this when doing the drag-fill changes too. Only one thing - could we call it |
|
hmm it's a bit long, I'm trying to use shorter grid option names, |
|
@ghiscoding as a user you'll see that key probably only once in your apps lifetime, so I guess it really doesnt matter whether its a couple more characters or not. |
|
Wondering if we aren't better to have something like an Because it's one step at a time, we always seem to end up having a bunch of booleans that may have a conflicting combination states. |
|
@6pac the issue is that some options are exclusive while others can be matched. the overall combinations matrix would explode with every new "mode" as users might need just that specific mix. the "wrong bool combo" on the other hand can be caught in the library and treated with an exception |
|
OK then |
indeed this new flag is technically working fine in combo with |
autoEditByKey to open editor by typing a charautoEditByKeypress to open editor by typing a char
When using and enabling both
autoEditandenableExcelCopyBuffer, starting a cell selection can conflict with the editing part. What this PR does, is to provide another grid optionautoEditByKeypress, which only starts editing when user starts typing a character via the keyboard, this avoid conflicting with with cell selection.as you can see below, I focus on the cell, then start typing "123", Enter, .... and I assume that is the behavior you were looking for