install: add option to suppress color

Signed-off-by: Matt Hoosier <[email protected]>

Author: matthoosier-garmin

install

@@ -20,6 +20,7 @@
 # POSIX
 
 next=0
+no_color=0
 verbose=0
 version=1.8.1.2
 
@@ -36,6 +37,7 @@ install --prefix /usr/local
 Options:
 	--prefix/-P:		base bath where all files will be deployed (default /usr/local if root, ~/.local if not)
 	--next/-N:		install latest development version from git, instead of the latest stable release.
+	--no-color:		disable color formatting
 	--help/-h:		show this message
 	-v:			show more verbosity
 EOF
@@ -49,6 +51,10 @@ while :; do
 			show_help
 			exit
 			;;
+		--no-color)
+			shift
+			no_color=1
+			;;
 		-v | --verbose)
 			shift
 			verbose=1
@@ -69,6 +75,17 @@ while :; do
 	esac
 done
 
+# if we're in not a tty, don't use colors
+BOLD_GREEN=""
+BOLD_RED=""
+CLEAR=""
+if [ -t 0 ] && [ -t 1 ] && [ "${no_color}" -ne 1 ]; then
+	# we're in a tty, use colors
+	BOLD_GREEN='\033[1;32m'
+	BOLD_RED='\033[1;31m'
+	CLEAR='\033[0m'
+fi
+
 if  [ -z "${prefix}" ]; then
 	prefix="/usr/local"
 	# in case we're not root, just default to the home directory
@@ -131,7 +148,10 @@ if [ -e "${curr_dir}/distrobox-enter" ]; then
 		done
 	fi
 else
-	printf >&2 "\033[1;31m Checking dependencies...\n\033[0m"
+	# echo -e is not defined in posix, and printing with %s will not work
+	# for colors, so we're disabling this lint for color prints.
+	# shellcheck disable=SC2059
+	printf >&2 "${BOLD_RED} Checking dependencies...\n${CLEAR}"
 	# check that we have base dependencies
 	if ! {
 		command -v curl > /dev/null || command -v wget > /dev/null
@@ -147,7 +167,8 @@ else
 		download="wget -qO"
 	fi
 
-	printf >&2 "\033[1;31m Downloading...\n\033[0m"
+	# shellcheck disable=SC2059
+	printf >&2 "${BOLD_RED} Downloading...\n${CLEAR}"
 	if [ "${next}" -eq 0 ]; then
 		release_ver="89luca89/distrobox/archive/refs/tags/${version}.tar.gz"
 		release_name=$(basename "${release_ver}")
@@ -161,7 +182,8 @@ else
 	# download our target
 	${download} "${release_name}" "https://github.com/${release_ver}"
 	# uncompress
-	printf >&2 "\033[1;31m Unpacking...\n\033[0m"
+	# shellcheck disable=SC2059
+	printf >&2 "${BOLD_RED} Unpacking...\n${CLEAR}"
 	if [ "${verbose}" -ne 0 ]; then
 		tar xvf "${release_name}"
 	else
@@ -214,10 +236,14 @@ fi
 [ ! -w "${dest_path}" ] && printf >&2 "Cannot write into %s, permission denied.\n" "${dest_path}" && exit 1
 [ ! -w "${man_dest_path}" ] && printf >&2 "Cannot write into %s, permission denied.\n" "${man_dest_path}" && exit 1
 
-printf >&2 "\033[1;32m Installation successful!\n\033[0m"
-printf >&2 "\033[0m Shell scripts are located in \033[1;31m%s\n\033[0m" "${dest_path}"
-printf >&2 "\033[0m Manpages are located in \033[1;31m%s\n\033[0m" "${man_dest_path}"
+# shellcheck disable=SC2059
+printf >&2 "${BOLD_GREEN} Installation successful!\n${CLEAR}"
+# shellcheck disable=SC2059
+printf >&2 "${CLEAR} Shell scripts are located in ${BOLD_RED}%s\n${CLEAR}" "${dest_path}"
+# shellcheck disable=SC2059
+printf >&2 "${CLEAR} Manpages are located in ${BOLD_RED}%s\n${CLEAR}" "${man_dest_path}"
 
 if ! echo "${PATH}" | grep -q "${dest_path}"; then
-	printf >&2 "\033[0m Be sure that \033[1;31m%s\033[0m is in your \033[1;31m\$PATH\033[0m environment variable to be able to use distrobox without specifying the full path.\n\033[0m" "${dest_path}"
+	# shellcheck disable=SC2059
+	printf >&2 "${CLEAR} Be sure that ${BOLD_RED}%s${CLEAR} is in your ${BOLD_RED}\$PATH${CLEAR} environment variable to be able to use distrobox without specifying the full path.\n${CLEAR}" "${dest_path}"
 fi

uninstall

@@ -19,6 +19,7 @@
 
 # POSIX
 
+no_color=0
 verbose=0
 
 # Print usage to stdout.
@@ -32,6 +33,7 @@ show_help()
 uninstall --prefix /usr/local
 
 Options:
+	--no-color:		disable color formatting
 	--prefix/-P:		base bath where all files will be deployed (default /usr/local if root, ~/.local if not)
 	--help/-h:		show this message
 	-v:			show more verbosity
@@ -46,6 +48,10 @@ while :; do
 			show_help
 			exit
 			;;
+		--no-color)
+			shift
+			no_color=1
+			;;
 		-v | --verbose)
 			shift
 			verbose=1
@@ -69,6 +75,17 @@ while :; do
 	esac
 done
 
+# if we're in not a tty, don't use colors
+BOLD_GREEN=""
+BOLD_RED=""
+CLEAR=""
+if [ -t 0 ] && [ -t 1 ] && [ "${no_color}" -ne 1 ]; then
+	# we're in a tty, use colors
+	BOLD_GREEN='\033[1;32m'
+	BOLD_RED='\033[1;31m'
+	CLEAR='\033[0m'
+fi
+
 if  [ -z "${prefix}" ]; then
 	prefix="/usr/local"
 	# in case we're not root, just default to the home directory
@@ -104,6 +121,11 @@ done
 [  -e "${icon_dest_path}"/terminal-distrobox-icon.svg ] && rm "${icon_dest_path}"/terminal-distrobox-icon.svg
 [  -e "${icon_dest_path}"/distrobox ] && rm -rf "${icon_dest_path}"/distrobox
 
-printf >&2 "\033[1;32m Thank you for using Distrobox. Uninstall complete.\n\033[0m"
-printf >&2 "\033[0m Removed shell scripts located in \033[1;31m%s\n\033[0m" "${dest_path}"
-printf >&2 "\033[0m Removed manpages located in \033[1;31m%s\n\033[0m" "${man_dest_path}"
+# echo -e is not defined in posix, and printing with %s will not work
+# for colors, so we're disabling this lint for color prints.
+# shellcheck disable=SC2059
+printf >&2 "${BOLD_GREEN} Thank you for using Distrobox. Uninstall complete.\n${CLEAR}"
+# shellcheck disable=SC2059
+printf >&2 "${CLEAR} Removed shell scripts located in ${BOLD_RED}%s\n${CLEAR}" "${dest_path}"
+# shellcheck disable=SC2059
+printf >&2 "${CLEAR} Removed manpages located in ${BOLD_RED}%s\n${CLEAR}" "${man_dest_path}"