install: add option to suppress color #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Could you be so kind to rebase this PR against the latest changes in |
matthoosier-garmin
force-pushed
the
install-suppress-color
branch
from
a83677f to
9d1f816
Compare
Contributor
Author
Done! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
|
Thanks @matthoosier-garmin! I see some shellcheck errors above, for me this PR is very valuable, once these issues are sorted I'd be looking forward to merge it 👍 |
matthoosier-garmin
force-pushed
the
install-suppress-color
branch
from
9d1f816 to
28a655d
Compare
Contributor
Author
|
@dottorblaster: yes, saw the shellcheck stuff after rebasing. I don't think those checks were in place last time I submitted. Rebased again; I think they're cleaned up now. Let's see whether the CI comes back clean. |
dottorblaster
requested changes
Aug 22, 2025
Collaborator
dottorblaster
left a comment
dottorblaster
left a comment
There was a problem hiding this comment.
Just a tiny change request, could you try if the approach I'm suggesting works in the context of your patch?
Signed-off-by: Matt Hoosier <[email protected]>
matthoosier-garmin
force-pushed
the
install-suppress-color
branch
from
28a655d to
5cde06c
Compare
dottorblaster
approved these changes
Aug 22, 2025
Collaborator
dottorblaster
left a comment
dottorblaster
left a comment
There was a problem hiding this comment.
LGTM, thank you so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.