TableMaker task updated to use configurables for system type, event and track selections#5206
Merged
iarsene merged 5 commits intoAliceO2Group:devfrom Jan 19, 2021
Merged
TableMaker task updated to use configurables for system type, event and track selections#5206iarsene merged 5 commits intoAliceO2Group:devfrom
iarsene merged 5 commits intoAliceO2Group:devfrom
Conversation
added 2 commits
January 17, 2021 17:13
The task can also run now on both pp and PbPb data, by specifying the isPbPb bool parameter
Collaborator
|
Could the list of runs come from a CCDB object? Everything should be ready to do that already. You can check out the "globalEfficiency" tutorial. |
Collaborator
Author
|
In principle yes, if these run lists exist already then one can save having all the lists added manually in the utility function. I think this would be nice to interface with what the DPG will provide at some point. |
jgrosseo
requested changes
Jan 18, 2021
Collaborator
jgrosseo
left a comment
jgrosseo
left a comment
There was a problem hiding this comment.
As just discussed on mattermost, the hard coded run lists should be moved to CCDB. A better solution needs further discussion...
jgrosseo
approved these changes
Jan 19, 2021
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
…nd track selections (AliceO2Group#5206) * TableMaker task updated to use configurables for event and track cuts. The task can also run now on both pp and PbPb data, by specifying the isPbPb bool parameter * fixed missing braces for the fullCI test * clang fix * removed predefined run lists from HistogramsLibrary Co-authored-by: Ionut Arsene <iarsene@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TableMaker: