trying to fix debian deployment. Create temporary debian/control and changelog, added extra guards

Author: Havunen

.github/workflows/build-release-artifacts.yml

@@ -411,7 +411,13 @@ jobs:
           deb_upstream_version="${VERSION/-rc./~rc.}"
           deb_revision="${DEB_REVISION}"
           deb_version="${deb_upstream_version}-${deb_revision}"
-          pkg_root="dist/deb-root"
+          if [[ -e debian ]]; then
+            echo "::error title=Unexpected debian directory::The release workflow expects no repository debian/ directory."
+            exit 1
+          fi
+
+          trap 'rm -rf debian' EXIT
+          pkg_root="debian/gitcomet"
           mkdir -p "${pkg_root}/DEBIAN"
           mkdir -p "${pkg_root}/usr/bin"
           mkdir -p "${pkg_root}/usr/share/applications"
@@ -421,24 +427,60 @@ jobs:
           install -m644 dist/gitcomet.desktop "${pkg_root}/usr/share/applications/gitcomet.desktop"
           install -m644 assets/gitcomet-512.png "${pkg_root}/usr/share/icons/hicolor/512x512/apps/gitcomet.png"
 
-          shlib_depends="$(dpkg-shlibdeps -O "${pkg_root}/usr/bin/gitcomet" | sed -n 's/^shlibs:Depends=//p')"
-          depends="git"
-          if [[ -n "${shlib_depends}" ]]; then
-            depends="${depends}, ${shlib_depends}"
-          fi
-
           {
+            echo "Source: gitcomet"
+            echo "Maintainer: AutoExplore Oy <info@autoexplore.ai>"
+            echo "Section: utils"
+            echo "Priority: optional"
+            echo "Standards-Version: 4.7.0"
+            echo
             echo "Package: gitcomet"
-            echo "Version: ${deb_version}"
             echo "Architecture: ${DEB_ARCH}"
-            echo "Maintainer: AutoExplore Oy <info@autoexplore.ai>"
-            echo "Depends: ${depends}"
+            echo "Depends: git, \${shlibs:Depends}"
             echo "Section: utils"
             echo "Priority: optional"
             echo "Description: Fast, resource-efficient Git GUI written in Rust."
-          } > "${pkg_root}/DEBIAN/control"
+          } > debian/control
 
-          dpkg-deb --build "${pkg_root}" "dist/gitcomet_${deb_version}_${DEB_ARCH}.deb"
+          {
+            echo "gitcomet (${deb_version}) unstable; urgency=medium"
+            echo
+            echo "  * Release ${VERSION}."
+            echo
+            echo " -- AutoExplore Oy <info@autoexplore.ai>  $(date -Ru)"
+          } > debian/changelog
+
+          dpkg-shlibdeps -Tdebian/substvars "${pkg_root}/usr/bin/gitcomet"
+          dpkg-gencontrol -pgitcomet -P"${pkg_root}" -Tdebian/substvars
+
+          pkg_file="dist/gitcomet_${deb_version}_${DEB_ARCH}.deb"
+          dpkg-deb --build "${pkg_root}" "${pkg_file}"
+
+          package_name="$(dpkg-deb -f "${pkg_file}" Package)"
+          package_version="$(dpkg-deb -f "${pkg_file}" Version)"
+          package_architecture="$(dpkg-deb -f "${pkg_file}" Architecture)"
+          package_depends="$(dpkg-deb -f "${pkg_file}" Depends)"
+
+          if [[ "${package_name}" != "gitcomet" ]]; then
+            echo "::error title=Unexpected package name::Got ${package_name}."
+            exit 1
+          fi
+          if [[ "${package_version}" != "${deb_version}" ]]; then
+            echo "::error title=Unexpected package version::Got ${package_version}, expected ${deb_version}."
+            exit 1
+          fi
+          if [[ "${package_architecture}" != "${DEB_ARCH}" ]]; then
+            echo "::error title=Unexpected package architecture::Got ${package_architecture}, expected ${DEB_ARCH}."
+            exit 1
+          fi
+          if ! grep -Eq '(^|, )git($|, )' <<<"${package_depends}"; then
+            echo "::error title=Missing git dependency::Got ${package_depends}."
+            exit 1
+          fi
+          if [[ "${package_depends}" == "git" ]]; then
+            echo "::error title=Missing shared library dependencies::Got ${package_depends}."
+            exit 1
+          fi
 
       - name: Package AppImage
         if: ${{ matrix.build_appimage }}