Skip to content

Commit b7f2353

Browse files
authored
fix: update MAX_EVENT_SERIALIZATION_LENGTH and re-enable TXE tests in CI (backport #21020) (#21027)
Backport of #21020 to v4. Cherry-pick applied cleanly — no conflicts. ## Summary Two fixes: ### 1. Fix `MAX_EVENT_SERIALIZATION_LENGTH` mismatch PR #20840 changed `MAX_EVENT_LEN` from 12 to 10 in `yarn-project/txe/src/rpc_translator.ts` but forgot to update the corresponding Noir constant `MAX_EVENT_SERIALIZATION_LENGTH` in `txe_oracles.nr`. This caused the TXE oracle to return `10 * 5 = 50` fields while the Noir oracle declaration expected `12 * 5 = 60` fields, crashing the `emit_and_discover_event` test. ### 2. Re-enable TXE-dependent noir tests in CI The `build_and_test` function in `bootstrap.sh` had a guard that only ran TXE tests when no argument was passed, but CI always calls `build_and_test fast` or `build_and_test full`. This fix removes the conditional so TXE tests run in all CI modes. ClaudeBox log: http://ci.aztec-labs.com/ed670f8e16fb711b-1
1 parent 2776313 commit b7f2353

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

bootstrap.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -307,11 +307,9 @@ function build_and_test {
307307
if [ "$finished" == "$make_pid" ]; then
308308
make_pid=
309309

310-
if [ -z "${1:-}" ]; then
311-
# TODO: Handle this better to they can be run as part of the Makefile dependency tree.
312-
start_txes
313-
make noir-projects-txe-tests
314-
fi
310+
# TODO: Handle this better so they can be run as part of the Makefile dependency tree.
311+
start_txes
312+
make noir-projects-txe-tests
315313

316314
# Signal tests complete, handled by parallel -E STOP.
317315
echo STOP >> $test_cmds_file

noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use crate::protocol::{
1111
};
1212

1313
global MAX_PRIVATE_EVENTS_PER_TXE_QUERY: u32 = 5;
14-
global MAX_EVENT_SERIALIZATION_LENGTH: u32 = 12;
14+
global MAX_EVENT_SERIALIZATION_LENGTH: u32 = 10;
1515

1616
pub unconstrained fn deploy<let M: u32, let N: u32, let P: u32>(
1717
path: str<N>,
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
InvalidNote has a packed length of 10 fields, which exceeds the maximum allowed length of 9 fields
1+
InvalidNote has a packed length of 9 fields, which exceeds the maximum allowed length of 8 fields

0 commit comments

Comments
 (0)