-
-
Notifications
You must be signed in to change notification settings - Fork 57
Session management v3 #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshStrobl
requested changes
Oct 25, 2025
Member
JoshStrobl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me but would like an explanation on the rc.xml change.
This is adapted from Xfce4. The start script sets some environment variables, copies our configuration files to the correct user directory, and starts the Wayland compositor, in our case, labwc. They support running different compositors by passing it as an argument to the script, which is why they have the whole Opts thing. We may want that in the future too, so I left it in. Signed-off-by: Evan Maddock <[email protected]>
…session exe to test for the compositor startup
…e it hangs session startup
…we want to support others later we would follow the same wm naming convention in the startup script
… the display - this prevents screenshot crashing on first use on some setups
…ided by labwc not GSD
… put some bits back in that still work for us
25c809d to
bde2018
Compare
… than as an autostart - the intention here is to turn off labwc outputs and have BudgieDaemonV2 controlling the output
JoshStrobl
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Leverages Evans session work in the session-management-v2 branch (i.e. replaces that PR)
dependencies
Requires:
notes
If we want QT Oxygen styling out of the box we should also merge in @Kyuyrii PR into this branch - Oxygen styling is better for flatpak / snap based apps.Observation 1: X11 based apps do not appear to launch as an autostart - for example nemo-desktop. This is the same observation with wayfire. It appears with the autostart stuff occurs, DISPLAY=:0 is not available in the environment. XWAYLAND should do this. running nemo-desktop from a terminal post login launches correctly via xwaylandfixed with the reuse of labwc -SObservation 2: Firefox on ubuntu 25.10 doesnt launch via the icon-task-list. In the logs in mentions the missing display number. Odd.fixed with the reuse of labwc -SSubmitter Checklist
git rebase -i(if needed)