panel/plugin-manager: Don't free object owned by hashtable #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `g_hash_table_lookup`, the returned data is not owned by the caller. We should ref it so we don't have to worry about freeing vs not freeing later. Ref #766 Signed-off-by: Evan Maddock <[email protected]>
JoshStrobl
force-pushed
the
plugin-manager-fix
branch
from
699ed4c to
b4bf74a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling
g_hash_table_lookup, the returned data is not owned bythe caller. We should ref it so we don't have to worry about freeing vs
not freeing later.
Ref #766
Submitter Checklist
git rebase -i(if needed)