feat: use ethereum-cryptography for enr crypto#285
Merged
wemeetagain merged 2 commits intomasterfrom Jan 25, 2024
Merged
Conversation
By default, use ethereum-cryptography. Provide a more performant option for nodejs in the discv5 package, see the discv5 README for details.
This was referenced Jan 25, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make
@chainsafe/enrmore usable as a standalone library, we'd like to remove its heavy dependencybcryptoand replace it with something more suitable for cross-environment usage,ethereum-cryptography.For
@chainsafe/discv5, which already usesbcrypto, we can continue to use its enr crypto. This PR adds a side effect of switching enr crypto to usebcryptowhen importing from@chainsfafe/discv5.For users of
@chainsafe/discv5who would like to useethereum-cryptographyfor enr crypto, you can always override the enr crypto like so: