Skip to content

Conversation

@ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Nov 23, 2025

Description

A description of the change, what it does, and why it was made. If relevant (e.g. UI changes), please also provide screenshots/recordings:

Been meaning to add this for a while. Also a good opportunity to refactor some code where the .unwrap() uses were unnecessary to begin with.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested (including steps):

If this change affects the program, please also indicate which platforms were tested:

  • Windows
  • macOS (specify version below)
  • Linux (specify distro below)
  • Other (specify below)

Checklist

Ensure all of these are met:

  • If this is a code change, areas your change affects have been linted using (cargo fmt)
  • If this is a code change, your changes pass cargo clippy --all -- -D warnings
  • If this is a code change, new tests were added if relevant
  • If this is a code change, your changes pass cargo test
  • The change has been tested to work (see above) and doesn't appear to break other things
  • Documentation has been updated if needed (README.md, help menu, docs, configs, etc.)
  • There are no merge conflicts
  • You have reviewed the changes first
  • The pull request passes the provided CI pipeline

Other

Anything else that maintainers should know about this PR:

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

❌ Patch coverage is 74.26471% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.80%. Comparing base (85af7ba) to head (aee92f3).

Files with missing lines Patch % Lines
...rc/canvas/components/time_graph/base/time_chart.rs 56.09% 18 Missing ⚠️
src/collection/amd.rs 0.00% 6 Missing ⚠️
src/app/states.rs 0.00% 4 Missing ⚠️
src/collection/processes/unix/process_ext.rs 0.00% 3 Missing ⚠️
src/canvas/components/widget_carousel.rs 0.00% 2 Missing ⚠️
src/app/data/store.rs 0.00% 1 Missing ⚠️
src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
+ Coverage   42.74%   42.80%   +0.06%     
==========================================
  Files         115      115              
  Lines       16127    16152      +25     
==========================================
+ Hits         6893     6914      +21     
- Misses       9234     9238       +4     
Flag Coverage Δ
macos-14 37.95% <68.46%> (+0.03%) ⬆️
ubuntu-latest 44.31% <76.51%> (+0.06%) ⬆️
windows-2022 38.29% <70.63%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ClementTsang ClementTsang marked this pull request as ready for review November 23, 2025 04:25
@ClementTsang ClementTsang merged commit 86b35bc into main Nov 23, 2025
11 checks passed
@ClementTsang ClementTsang deleted the use_unwrap_used branch November 23, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant