Skip to content

Commit cf89655

Browse files
committed
Dropped node 18 support
1 parent 9ff3ac7 commit cf89655

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

.github/workflows/dotnet.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
matrix:
1515
os: [windows-latest, ubuntu-latest]
16-
node: ['18', '20', '22']
16+
node: ['20', '22']
1717
steps:
1818
- uses: actions/checkout@v4
1919
- name: Setup .NET

PdfJsSharp/PdfJsWrapper.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ namespace Codeuctivity.PdfjsSharp
1919
public class PdfJsWrapper : IDisposable
2020
{
2121
internal const int windowsMaxPathLength = 206;
22-
internal static readonly SemaphoreSlim semaphore = new SemaphoreSlim(1, 1);
22+
internal static readonly SemaphoreSlim semaphore = new(1, 1);
2323
internal bool useCustomNodeModulePath;
2424
internal string pathToNodeModules = default!;
2525
internal string pathToTempFolder = default!;
@@ -28,7 +28,7 @@ public class PdfJsWrapper : IDisposable
2828
/// <summary>
2929
/// Supported node versions
3030
/// </summary>
31-
private readonly ImmutableArray<int> SupportedNodeVersions = ImmutableArray.Create(18, 20, 22);
31+
private readonly ImmutableArray<int> SupportedNodeVersions = [20, 22];
3232

3333
internal bool IsInitialized { get; set; }
3434

PdfJsSharpTests/NodeVersionDetectorTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public void ShouldDetectNodeVersionAsync()
1616
[Fact]
1717
public void ShouldDetermineInstalledVersionAsync()
1818
{
19-
var actualInstalledVersion = NodeVersionDetector.CheckRequiredNodeVersionInstalled(Rasterizer.NodeExecutablePath, new[] { 8, 18, 20, 22 });
19+
var actualInstalledVersion = NodeVersionDetector.CheckRequiredNodeVersionInstalled(Rasterizer.NodeExecutablePath, new[] { 8, 20, 22 });
2020
Assert.True(actualInstalledVersion > 6);
2121
}
2222

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Brings [PDF.js](https://github.com/mozilla/pdf.js) to .net
1313
get
1414

1515
- NodeJs
16-
- node 18, 20 or 22 x64 (older node versions are supported by older PDFjsSharp versions)
16+
- node 20 or 22 x64 (older node versions are supported by older PDFjsSharp versions)
1717

1818
## HowTo use
1919

0 commit comments

Comments
 (0)