This repository was archived by the owner on Oct 2, 2023. It is now read-only.
feat: allow conan >=1.41.0, <2#45
Merged
jkowalleck merged 1 commit intoCycloneDX:mainfrom Dec 11, 2022
Merged
Conversation
Signed-off-by: Brandner Simon (BEG/EES3) <Simon.Brandner@de.bosch.com>
volviq
force-pushed
the
issues/3-pyproject-do-not-hardcode-conan-version
branch
from
415ec31 to
de088b3
Compare
coderpatros
approved these changes
Oct 10, 2022
jkowalleck
approved these changes
Dec 11, 2022
jkowalleck
changed the title
>=1.41.0, <2
jkowalleck
changed the title
>=1.41.0, <2conan >=1.41.0, <2
jkowalleck
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also permit conan version up to 1.49.x to avoid conflicts in environment setup.
Possibly also higher (1.5x) would be feasible but do not seem critical right now.
Unclear to me:
Is it required to also update:
https://github.com/CycloneDX/cyclonedx-conan/blob/main/poetry.lock
to get the pip repository dependency information updated? This seems to be a generated file, so I'd rather ask the admins of the project to update it with less hardcoded versions.