Skip to content

Commit 9643c5c

Browse files
committed
Increase Yarp to instrument 1.0.0 up from 1.1.0
1 parent 91d944f commit 9643c5c

5 files changed

Lines changed: 4 additions & 10 deletions

File tree

tracer/build/supported_calltargets.g.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8967,7 +8967,7 @@
89678967
],
89688968
"MinimumVersion": {
89698969
"Item1": 1,
8970-
"Item2": 1,
8970+
"Item2": 0,
89718971
"Item3": 0
89728972
},
89738973
"MaximumVersion": {

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Http/HttpClient/SocketsHttpHandler/YarpForwarderHttpClientFactoryIntegration.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.Http.HttpClient.SocketsH
2222
MethodName = "ConfigureHandler",
2323
ReturnTypeName = ClrNames.Void,
2424
ParameterTypeNames = new[] { "Yarp.ReverseProxy.Forwarder.ForwarderHttpClientContext", "System.Net.Http.SocketsHttpHandler" },
25-
MinimumVersion = "1.1.0",
25+
MinimumVersion = "1.0.0",
2626
MaximumVersion = "2.*.*",
2727
IntegrationName = IntegrationName)]
2828
[Browsable(false)]

tracer/src/Datadog.Tracer.Native/Generated/generated_calltargets.g.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,7 @@ std::vector<CallTargetDefinition3> callTargets =
793793
{(WCHAR*)WStr("System.Net.Http"),(WCHAR*)WStr("System.Net.Http.SocketsHttpHandler"),(WCHAR*)WStr("SendAsync"),sig302,3,4,0,0,10,65535,65535,assemblyName,(WCHAR*)WStr("Datadog.Trace.ClrProfiler.AutoInstrumentation.Http.HttpClient.SocketsHttpHandler.SocketsHttpHandlerIntegration"),CallTargetKind::Default,1,15},
794794
{(WCHAR*)WStr("System.Net.Http"),(WCHAR*)WStr("System.Net.Http.WinHttpHandler"),(WCHAR*)WStr("SendAsync"),sig302,3,4,0,0,10,65535,65535,assemblyName,(WCHAR*)WStr("Datadog.Trace.ClrProfiler.AutoInstrumentation.Http.HttpClient.WinHttpHandler.WinHttpHandlerIntegration"),CallTargetKind::Default,1,15},
795795
{(WCHAR*)WStr("System.Net.Http.WinHttpHandler"),(WCHAR*)WStr("System.Net.Http.WinHttpHandler"),(WCHAR*)WStr("SendAsync"),sig302,3,4,0,0,10,65535,65535,assemblyName,(WCHAR*)WStr("Datadog.Trace.ClrProfiler.AutoInstrumentation.Http.HttpClient.WinHttpHandler.WinHttpHandlerIntegration"),CallTargetKind::Default,1,15},
796-
{(WCHAR*)WStr("Yarp.ReverseProxy"),(WCHAR*)WStr("Yarp.ReverseProxy.Forwarder.ForwarderHttpClientFactory"),(WCHAR*)WStr("ConfigureHandler"),sig397,3,1,1,0,2,65535,65535,assemblyName,(WCHAR*)WStr("Datadog.Trace.ClrProfiler.AutoInstrumentation.Http.HttpClient.SocketsHttpHandler.YarpForwarderHttpClientFactoryIntegration"),CallTargetKind::Default,1,8},
796+
{(WCHAR*)WStr("Yarp.ReverseProxy"),(WCHAR*)WStr("Yarp.ReverseProxy.Forwarder.ForwarderHttpClientFactory"),(WCHAR*)WStr("ConfigureHandler"),sig397,3,1,0,0,2,65535,65535,assemblyName,(WCHAR*)WStr("Datadog.Trace.ClrProfiler.AutoInstrumentation.Http.HttpClient.SocketsHttpHandler.YarpForwarderHttpClientFactoryIntegration"),CallTargetKind::Default,1,8},
797797
{(WCHAR*)WStr("amqmdnetstd"),(WCHAR*)WStr("IBM.WMQ.MQDestination"),(WCHAR*)WStr("Get"),sig332,4,9,0,0,9,65535,65535,assemblyName,(WCHAR*)WStr("Datadog.Trace.ClrProfiler.AutoInstrumentation.IbmMq.GetIntegration"),CallTargetKind::Default,1,15},
798798
{(WCHAR*)WStr("amqmdnetstd"),(WCHAR*)WStr("IBM.WMQ.MQDestination"),(WCHAR*)WStr("Put"),sig333,3,9,0,0,9,65535,65535,assemblyName,(WCHAR*)WStr("Datadog.Trace.ClrProfiler.AutoInstrumentation.IbmMq.PutIntegration"),CallTargetKind::Default,1,15},
799799
{(WCHAR*)WStr("Microsoft.Extensions.Logging"),(WCHAR*)WStr("Microsoft.Extensions.Logging.LoggerFactory"),(WCHAR*)WStr(".ctor"),sig357,3,2,0,0,3,65535,65535,assemblyName,(WCHAR*)WStr("Datadog.Trace.ClrProfiler.AutoInstrumentation.Logging.ILogger.DirectSubmission.LoggerFactoryConstructorIntegration"),CallTargetKind::Default,1,15},

tracer/test/test-applications/integrations/Samples.Yarp.DistributedTracing/Samples.Yarp.DistributedTracing.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.7.0" />
2222
<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.11.1" />
2323
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.7.0" />
24-
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.7.0" />
2524
</ItemGroup>
2625

2726
</Project>

tracer/test/test-applications/integrations/Samples.Yarp.DistributedTracing/Startup.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,7 @@ public void ConfigureServices(IServiceCollection services)
4343
.ConfigureResource(r => r.AddService("yarp-sample"))
4444
.WithTracing(tracing => tracing
4545
.AddAspNetCoreInstrumentation()
46-
.AddHttpClientInstrumentation()
47-
.AddOtlpExporter(o =>
48-
{
49-
// Use a non-routable endpoint so exports silently fail
50-
o.Endpoint = new Uri("http://192.0.2.1:4317");
51-
}));
46+
.AddHttpClientInstrumentation());
5247
#endif
5348
}
5449

0 commit comments

Comments
 (0)