[New] Apply blend renderer to hillshade #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update project.pbxproj
des12437
requested review from
a team,
CalebRas and
philium
and removed request for
a team
philium
reviewed
May 6, 2025
Contributor
philium
left a comment
philium
left a comment
There was a problem hiding this comment.
Please add the new Swift source files to the Copy Source Code Files build phase.
Shared/Samples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.Model.swift
Outdated
Show resolved
Hide resolved
...mples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.SettingsView.swift
Outdated
Show resolved
Hide resolved
...mples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.SettingsView.swift
Outdated
Show resolved
Hide resolved
...mples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.SettingsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.swift
Outdated
Show resolved
Hide resolved
philium
reviewed
May 6, 2025
...mples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.SettingsView.swift
Show resolved
Hide resolved
Shared/Samples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.swift
Outdated
Show resolved
Hide resolved
philium
previously approved these changes
May 6, 2025
Contributor
philium
left a comment
philium
left a comment
There was a problem hiding this comment.
Thanks for making those changes!
CalebRas
reviewed
May 6, 2025
Collaborator
CalebRas
left a comment
CalebRas
left a comment
There was a problem hiding this comment.
Looks good! Just some suggestions and questions
Shared/Samples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.swift
Outdated
Show resolved
Hide resolved
...mples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.SettingsView.swift
Outdated
Show resolved
Hide resolved
...mples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.SettingsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Apply blend renderer to hillshade/README.metadata.json
Outdated
Show resolved
Hide resolved
...mples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.SettingsView.swift
Show resolved
Hide resolved
CalebRas
previously approved these changes
May 7, 2025
philium
reviewed
May 7, 2025
Shared/Samples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Apply blend renderer to hillshade/ApplyBlendRendererToHillshadeView.swift
Outdated
Show resolved
Hide resolved
philium
approved these changes
May 7, 2025
CalebRas
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Apply blend renderer to hillshadeinVisualizationcategory.URL to README: URL
Linked Issue(s)
swift/issues/6830How To Test
Open the sample and adjust the
Renderer Settingsand verify that the map updates.Screenshots