[Fix] PopupView deprecation warnings
#661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebRas
commented
Jul 15, 2025
Shared/Samples/Set up location-driven geotriggers/SetUpLocationDrivenGeotriggersView.swift
Show resolved
Hide resolved
CalebRas
requested review from
a team,
dfeinzimer and
njarecha
and removed request for
a team
dfeinzimer
approved these changes
Jul 21, 2025
njarecha
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes uses of the deprecated
PopupView.init(popup:isPresented:)in:Configure clustersDisplay clustersShow popupSet up location-driven geotriggersfloatingPaneluses also had to be replaced since the navigation stack used by the new Popup View initializer would interfere with the one in the Samples.Display clustersrequired some additional changes to handle the "Geoelements" list that is shown in the presentation along with the popup.Linked Issue(s)
swift/issues/7030PopupView- Update initializer to match FeatureForm arcgis-maps-sdk-swift-toolkit#1207How To Test
swift-daily.Screenshots