Skip to content

Conversation

@Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Nov 27, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

⚠️ In order to avoid any disruption, the frontend related PR must be merged and deployed right after CoreApi (Sample versus Generic)

Contributes to #6130

Changes

In this PR, we migrate the Sample Feature Health Provider to Webhook:

  • Updated the model choices
  • Updated relevant tests
  • Renamed all occurrences of sample to generic
  • ⚠️ Migration involved

How did you test this code?

  • Tests
  • Running migration locally up and down
image image

Edit to webhook - same records
image

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner November 27, 2025 13:49
@Zaimwa9 Zaimwa9 requested review from khvn26 and removed request for a team November 27, 2025 13:49
@vercel
Copy link

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Nov 27, 2025 3:03pm
flagsmith-frontend-preview Ignored Ignored Preview Nov 27, 2025 3:03pm
flagsmith-frontend-staging Ignored Ignored Preview Nov 27, 2025 3:03pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Nov 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-6332 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-6332 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6332 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-6332 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6332 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6332 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6332 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6332 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6332 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6332 Finished ✅ Results

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 27, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 10

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.02%. Comparing base (2ecafd9) to head (3aba086).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6332   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files        1280     1281    +1     
  Lines       45406    45461   +55     
=======================================
+ Hits        44508    44563   +55     
  Misses        898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 27, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 27, 2025
@Zaimwa9 Zaimwa9 changed the title feat: renamed-feature-health-sample-to-generic ⚠️ feat: renamed-feature-health-sample-to-webhook ⚠️ Nov 27, 2025
@Zaimwa9 Zaimwa9 requested a review from khvn26 November 27, 2025 15:12
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Zaimwa9 Zaimwa9 merged commit 71fcd4b into main Dec 1, 2025
33 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/migrate-sample-to-generic branch December 1, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants