bug #4220 NativeFunctionInvocationFixer - namespaced strict to remove backslash (kubawerlos)

This PR was merged into the 2.14-dev branch.

Discussion
----------

NativeFunctionInvocationFixer - namespaced strict to remove backslash

When we want only namespaced calls to have `\` in strict mode we should remove `\` for global namespace call.

Commits
-------

1241bda NativeFunctionInvocationFixer - namespaced strict to remove backslash

Author: keradus

src/Fixer/FunctionNotation/NativeFunctionInvocationFixer.php

@@ -182,7 +182,7 @@ public function isRisky()
     protected function applyFix(\SplFileInfo $file, Tokens $tokens)
     {
         if ('all' === $this->configuration['scope']) {
-            $this->fixFunctionCalls($tokens, $this->functionFilter, 0, \count($tokens) - 1);
+            $this->fixFunctionCalls($tokens, $this->functionFilter, 0, \count($tokens) - 1, false);
 
             return;
         }
@@ -192,11 +192,7 @@ protected function applyFix(\SplFileInfo $file, Tokens $tokens)
         // 'scope' is 'namespaced' here
         /** @var NamespaceAnalysis $namespace */
         foreach (array_reverse($namespaces) as $namespace) {
-            if ('' === $namespace->getFullName()) {
-                continue;
-            }
-
-            $this->fixFunctionCalls($tokens, $this->functionFilter, $namespace->getScopeStartIndex(), $namespace->getScopeEndIndex());
+            $this->fixFunctionCalls($tokens, $this->functionFilter, $namespace->getScopeStartIndex(), $namespace->getScopeEndIndex(), '' === $namespace->getFullName());
         }
     }
 
@@ -264,8 +260,9 @@ protected function createConfigurationDefinition()
      * @param callable $functionFilter
      * @param int      $start
      * @param int      $end
+     * @param bool     $tryToRemove
      */
-    private function fixFunctionCalls(Tokens $tokens, callable $functionFilter, $start, $end)
+    private function fixFunctionCalls(Tokens $tokens, callable $functionFilter, $start, $end, $tryToRemove)
     {
         $functionsAnalyzer = new FunctionsAnalyzer();
 
@@ -277,8 +274,11 @@ private function fixFunctionCalls(Tokens $tokens, callable $functionFilter, $sta
 
             $prevIndex = $tokens->getPrevMeaningfulToken($index);
 
-            if (!$functionFilter($tokens[$index]->getContent())) {
-                if ($this->configuration['strict'] && $tokens[$prevIndex]->isGivenKind(T_NS_SEPARATOR)) {
+            if (!$functionFilter($tokens[$index]->getContent()) || $tryToRemove) {
+                if (!$this->configuration['strict']) {
+                    continue;
+                }
+                if ($tokens[$prevIndex]->isGivenKind(T_NS_SEPARATOR)) {
                     $tokens->clearTokenAndMergeSurroundingWhitespace($prevIndex);
                 }
 

tests/Fixer/FunctionNotation/NativeFunctionInvocationFixerTest.php

@@ -579,6 +579,20 @@ public function & strlen($name) {
                     'strict' => true,
                 ],
             ],
+            'scope namespaced and strict enabled' => [
+                '<?php
+                    $a = not_compiler_optimized_function();
+                    $b = intval($c);
+                ',
+                '<?php
+                    $a = \not_compiler_optimized_function();
+                    $b = \intval($c);
+                ',
+                [
+                    'scope' => 'namespaced',
+                    'strict' => true,
+                ],
+            ],
         ];
     }