minor #4532 DX: ensure data providers are used (kubawerlos)

This PR was squashed before being merged into the 2.15 branch (closes #4532).

Discussion
----------

DX: ensure data providers are used

Commits
-------

9cb7bf2 DX: ensure data providers are used

Author: SpacePossum

tests/AutoReview/ProjectCodeTest.php

@@ -275,13 +275,13 @@ static function (\ReflectionMethod $reflectionMethod) use ($reflectionClass) {
      */
     public function testThatDataProvidersAreCorrectlyNamed($testClassName)
     {
-        $dataProviderMethodNames = $this->getDataProviderMethodNames($testClassName);
+        $usedDataProviderMethodNames = $this->getUsedDataProviderMethodNames($testClassName);
 
         if (empty($dataProviderMethodNames)) {
             $this->addToAssertionCount(1); // no data providers to test, all good!
         }
 
-        foreach ($dataProviderMethodNames as $dataProviderMethodName) {
+        foreach ($usedDataProviderMethodNames as $dataProviderMethodName) {
             static::assertRegExp('/^provide[A-Z]\S+Cases$/', $dataProviderMethodName, sprintf(
                 'Data provider in "%s" with name "%s" is not correctly named.',
                 $testClassName,
@@ -290,6 +290,38 @@ public function testThatDataProvidersAreCorrectlyNamed($testClassName)
         }
     }
 
+    /**
+     * @dataProvider provideTestClassCases
+     *
+     * @param string $testClassName
+     */
+    public function testThatDataProvidersAreUsed($testClassName)
+    {
+        $reflectionClass = new \ReflectionClass($testClassName);
+
+        $definedDataProviders = array_filter(
+            $reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC),
+            static function (\ReflectionMethod $reflectionMethod) use ($reflectionClass) {
+                return $reflectionMethod->getDeclaringClass()->getName() === $reflectionClass->getName()
+                    && 'provide' === substr($reflectionMethod->getName(), 0, 7);
+            }
+        );
+
+        if ($definedDataProviders === []) {
+            $this->addToAssertionCount(1); // no methods to test, all good!
+        }
+
+        $usedDataProviderMethodNames = $this->getUsedDataProviderMethodNames($testClassName);
+
+        foreach ($definedDataProviders as $definedDataProvider) {
+            static::assertContains(
+                $definedDataProvider->getName(),
+                $usedDataProviderMethodNames,
+                sprintf('Data provider in "%s" with name "%s" is not used.', $definedDataProvider->getDeclaringClass()->getName(), $definedDataProvider->getName())
+            );
+        }
+    }
+
     /**
      * @dataProvider provideClassesWherePregFunctionsAreForbiddenCases
      *
@@ -406,7 +438,7 @@ static function ($className) {
         );
     }
 
-    private function getDataProviderMethodNames($testClassName)
+    private function getUsedDataProviderMethodNames($testClassName)
     {
         $dataProviderMethodNames = [];
         $tokens = Tokens::fromCode(file_get_contents(

tests/Fixer/ConstantNotation/NativeConstantInvocationFixerTest.php

@@ -222,7 +222,7 @@ public function provideFix70WithDefaultConfigurationCases()
     }
 
     /**
-     * @dataProvider provideFix70WithDefaultConfigurationCases
+     * @dataProvider provideFix71WithDefaultConfigurationCases
      *
      * @param string      $expected
      * @param null|string $input

tests/Fixer/FunctionNotation/NoUnreachableDefaultArgumentValueFixerTest.php

@@ -181,7 +181,7 @@ public function testFix56($expected, $input = null)
     /**
      * @return array
      */
-    public function provideFix56cases()
+    public function provideFix56Cases()
     {
         return [
             [