DX: remove Utils::splitLines

Author: kubawerlos

src/DocBlock/DocBlock.php

@@ -12,7 +12,7 @@
 
 namespace PhpCsFixer\DocBlock;
 
-use PhpCsFixer\Utils;
+use PhpCsFixer\Preg;
 
 /**
  * This class represents a docblock.
@@ -44,7 +44,7 @@ class DocBlock
      */
     public function __construct($content)
     {
-        foreach (Utils::splitLines($content) as $line) {
+        foreach (Preg::split('/([^\n\r]+\R*)/', $content, -1, PREG_SPLIT_NO_EMPTY | PREG_SPLIT_DELIM_CAPTURE) as $line) {
             $this->lines[] = new Line($line);
         }
     }

src/Utils.php

@@ -82,25 +82,6 @@ public static function cmpInt($a, $b)
         return $a < $b ? -1 : 1;
     }
 
-    /**
-     * Split a multi-line string up into an array of strings.
-     *
-     * We're retaining a newline character at the end of non-blank lines, and
-     * discarding other lines, so this function is unsuitable for anyone for
-     * wishing to retain the exact number of line endings. If a single-line
-     * string is passed, we'll just return an array with a element.
-     *
-     * @param string $content
-     *
-     * @return string[]
-     */
-    public static function splitLines($content)
-    {
-        Preg::matchAll("/[^\n\r]+[\r\n]*/", $content, $matches);
-
-        return $matches[0];
-    }
-
     /**
      * Calculate the trailing whitespace.
      *

tests/UtilsTest.php

@@ -90,39 +90,6 @@ public function provideCmpIntCases()
         ];
     }
 
-    /**
-     * @param array  $expected
-     * @param string $input
-     *
-     * @dataProvider provideSplitLinesCases
-     */
-    public function testSplitLines(array $expected, $input)
-    {
-        $this->assertSame($expected, Utils::splitLines($input));
-    }
-
-    public function provideSplitLinesCases()
-    {
-        return [
-            [
-                ["\t aaa\n", " bbb\n", "\t"],
-                "\t aaa\n bbb\n\t",
-            ],
-            [
-                ["aaa\r\n", " bbb\r\n"],
-                "aaa\r\n bbb\r\n",
-            ],
-            [
-                ["aaa\r\n", " bbb\n"],
-                "aaa\r\n bbb\n",
-            ],
-            [
-                ["aaa\r\n\n\n\r\n", " bbb\n"],
-                "aaa\r\n\n\n\r\n bbb\n",
-            ],
-        ];
-    }
-
     /**
      * @param string       $spaces
      * @param array|string $input  token prototype