minor #4981 Prevent error in CTTest::testConstants (for PHP8) (guilliamxavier)

julienfalque · julienfalque · commit 6b3f163e7368 · 2020-05-31T20:03:31.000Z
This PR was merged into the 2.15 branch. Discussion ---------- Prevent error in CTTest::testConstants (for PHP8) Noticed in https://travis-ci.org/github/FriendsOfPHP/PHP-CS-Fixer/jobs/692842752#L800 Even before PHP 8, I find the test cleaner like this Commits ------- 1a121e0 Prevent error in CTTest::testConstants (for PHP8)
diff --git a/tests/Tokenizer/CTTest.php b/tests/Tokenizer/CTTest.php
@@ -74,7 +74,7 @@ public function testGetNameNotExists()
     public function testConstants($name, $value)
     {
         static::assertGreaterThan(10000, $value);
-        static::assertNull(@\constant($name), 'The CT name must not use native T_* name.');
+        static::assertFalse(\defined($name), 'The CT name must not use native T_* name.');
     }
 
     public function provideConstantsCases()

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public function testGetNameNotExists()`
`74`	`74`	`public function testConstants($name, $value)`
`75`	`75`	`{`
`76`	`76`	`static::assertGreaterThan(10000, $value);`
`77`		`- static::assertNull(@\constant($name), 'The CT name must not use native T_* name.');`
	`77`	`+ static::assertFalse(\defined($name), 'The CT name must not use native T_* name.');`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`public function provideConstantsCases()`