PHP7.4 - Add "str_split" => "mb_str_split" mapping.

Author: SpacePossum

src/Fixer/Alias/MbStrFunctionsFixer.php

@@ -27,18 +27,19 @@ final class MbStrFunctionsFixer extends AbstractFunctionReferenceFixer
     /**
      * @var array the list of the string-related function names and their mb_ equivalent
      */
-    private static $functions = [
+    private static $functionsMap = [
+        'str_split' => ['alternativeName' => 'mb_str_split', 'argumentCount' => [1, 2, 3]],
+        'stripos' => ['alternativeName' => 'mb_stripos', 'argumentCount' => [2, 3]],
+        'stristr' => ['alternativeName' => 'mb_stristr', 'argumentCount' => [2, 3]],
         'strlen' => ['alternativeName' => 'mb_strlen', 'argumentCount' => [1]],
         'strpos' => ['alternativeName' => 'mb_strpos', 'argumentCount' => [2, 3]],
+        'strrchr' => ['alternativeName' => 'mb_strrchr', 'argumentCount' => [2]],
+        'strripos' => ['alternativeName' => 'mb_strripos', 'argumentCount' => [2, 3]],
         'strrpos' => ['alternativeName' => 'mb_strrpos', 'argumentCount' => [2, 3]],
-        'substr' => ['alternativeName' => 'mb_substr', 'argumentCount' => [2, 3]],
+        'strstr' => ['alternativeName' => 'mb_strstr', 'argumentCount' => [2, 3]],
         'strtolower' => ['alternativeName' => 'mb_strtolower', 'argumentCount' => [1]],
         'strtoupper' => ['alternativeName' => 'mb_strtoupper', 'argumentCount' => [1]],
-        'stripos' => ['alternativeName' => 'mb_stripos', 'argumentCount' => [2, 3]],
-        'strripos' => ['alternativeName' => 'mb_strripos', 'argumentCount' => [2, 3]],
-        'strstr' => ['alternativeName' => 'mb_strstr', 'argumentCount' => [2, 3]],
-        'stristr' => ['alternativeName' => 'mb_stristr', 'argumentCount' => [2, 3]],
-        'strrchr' => ['alternativeName' => 'mb_strrchr', 'argumentCount' => [2]],
+        'substr' => ['alternativeName' => 'mb_substr', 'argumentCount' => [2, 3]],
         'substr_count' => ['alternativeName' => 'mb_substr_count', 'argumentCount' => [2, 3, 4]],
     ];
 
@@ -85,8 +86,15 @@ public function isCandidate(Tokens $tokens)
      */
     protected function applyFix(\SplFileInfo $file, Tokens $tokens)
     {
+        $functions = array_filter(
+            self::$functionsMap,
+            static function ($mapping) {
+                return \function_exists($mapping['alternativeName']);
+            }
+        );
+
         $argumentsAnalyzer = new ArgumentsAnalyzer();
-        foreach (self::$functions as $functionIdentity => $functionReplacement) {
+        foreach ($functions as $functionIdentity => $functionReplacement) {
             $currIndex = 0;
             while (null !== $currIndex) {
                 // try getting function reference and translate boundaries for humans

tests/Fixer/Alias/MbStrFunctionsFixerTest.php

@@ -37,7 +37,7 @@ public function testFix($expected, $input = null)
 
     public function provideFixCases()
     {
-        return [
+        $cases = [
             ['<?php $x = "strlen";'],
             ['<?php $x = Foo::strlen("bar");'],
             ['<?php $x = new strlen("bar");'],
@@ -62,5 +62,18 @@ public function strtolower($a);
                 }',
             ],
         ];
+
+        if (\function_exists('mb_str_split')) {
+            $cases[] = [
+                '<?php $a = mb_str_split($a);',
+                '<?php $a = str_split($a);',
+            ];
+        } else {
+            $cases[] = [
+                '<?php $a = str_split($a);',
+            ];
+        }
+
+        return $cases;
     }
 }