minor #4431 DX: test that default config is not passed in RuleSet (kubawerlos)

This PR was merged into the 2.12 branch.

Discussion
----------

DX: test that default config is not passed in RuleSet

Commits
-------

3654e58 DX: test that default config is not passed in RuleSet

Author: SpacePossum

src/RuleSet.php

@@ -68,7 +68,7 @@ final class RuleSet implements RuleSetInterface
             'cast_spaces' => true,
             'class_attributes_separation' => ['elements' => ['method']],
             'class_definition' => ['single_line' => true],
-            'concat_space' => ['spacing' => 'none'],
+            'concat_space' => true,
             'declare_equal_normalize' => true,
             'function_typehint_space' => true,
             'include' => true,
@@ -94,7 +94,7 @@ final class RuleSet implements RuleSetInterface
             ]],
             'no_leading_import_slash' => true,
             'no_leading_namespace_whitespace' => true,
-            'no_mixed_echo_print' => ['use' => 'echo'],
+            'no_mixed_echo_print' => true,
             'no_multiline_whitespace_around_double_arrow' => true,
             'no_short_bool_cast' => true,
             'no_singleline_whitespace_before_semicolons' => true,
@@ -178,9 +178,7 @@ final class RuleSet implements RuleSetInterface
             ],
             'no_alias_functions' => true,
             'no_homoglyph_names' => true,
-            'non_printable_character' => [
-                'use_escape_sequences_in_strings' => false,
-            ],
+            'non_printable_character' => true,
             'php_unit_construct' => true,
             'psr4' => true,
             'self_accessor' => true,
@@ -322,7 +320,7 @@ final class RuleSet implements RuleSetInterface
         ],
         '@PHPUnit50Migration:risky' => [
             '@PHPUnit48Migration:risky' => true,
-            'php_unit_dedicate_assert' => ['target' => PhpUnitTargetVersion::VERSION_5_0],
+            'php_unit_dedicate_assert' => true,
         ],
         '@PHPUnit52Migration:risky' => [
             '@PHPUnit50Migration:risky' => true,

tests/RuleSetTest.php

@@ -18,6 +18,7 @@
 use PhpCsFixer\Fixer\DeprecatedFixerInterface;
 use PhpCsFixer\Fixer\FixerInterface;
 use PhpCsFixer\Fixer\PhpUnit\PhpUnitTargetVersion;
+use PhpCsFixer\FixerConfiguration\DeprecatedFixerOptionInterface;
 use PhpCsFixer\FixerFactory;
 use PhpCsFixer\RuleSet;
 
@@ -71,6 +72,38 @@ public function testIfAllRulesInSetsExists($setName, $ruleName, $ruleConfig)
         }
     }
 
+    /**
+     * @param string     $setName
+     * @param string     $ruleName
+     * @param array|bool $ruleConfig
+     *
+     * @dataProvider provideAllRulesFromSetsCases
+     */
+    public function testThatDefaultConfigIsNotPassed($setName, $ruleName, $ruleConfig)
+    {
+        $factory = new FixerFactory();
+        $factory->registerBuiltInFixers();
+        $factory->useRuleSet(new RuleSet([$ruleName => true]));
+
+        $fixer = current($factory->getFixers());
+
+        if (!$fixer instanceof ConfigurableFixerInterface) {
+            $this->addToAssertionCount(1);
+
+            return;
+        }
+
+        $defaultConfig = [];
+        foreach ($fixer->getConfigurationDefinition()->getOptions() as $option) {
+            if ($option instanceof DeprecatedFixerOptionInterface) {
+                continue;
+            }
+            $defaultConfig[$option->getName()] = $option->getDefault();
+        }
+
+        static::assertNotSame($defaultConfig, $ruleConfig, sprintf('Rule "%s" (in RuleSet "%s") has default config passed.', $ruleName, $setName));
+    }
+
     /**
      * @param string $ruleName
      * @param string $setName