Skip to content

Commit e5de921

Browse files
committed
minor #4949 Fixed build readme on Windows fails if using Git Bash (Mintty) (8ctopus)
This PR was merged into the 2.15 branch. Discussion ---------- Fixed build readme on Windows fails if using Git Bash (Mintty) Git on Windows comes with Git Bash which uses Mintty. In Git Bash the command to update the README.rst `php php-cs-fixer readme > README.rst` fails with error: ``` $ php php-cs-fixer readme > README.rst stdout is not a tty ``` This modest contribution fixes it in Git Bash but also works in the regular command line. Commits ------- 8e39a0a Fixed build readme on Windows fails if using Git Bash (Mintty)
2 parents 96ec6f7 + 8e39a0a commit e5de921

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ If you need any help, don't hesitate to ask the community on [Gitter](https://gi
1313
* Make changes.
1414
* If you are adding functionality or fixing a bug - add a test! Prefer adding new test cases over modifying existing ones.
1515
* Make sure there is no trailing spaces in code: `./check_trailing_spaces.sh`.
16-
* Regenerate README: `php php-cs-fixer readme > README.rst`. Do not modify `README.rst` manually!
16+
* Regenerate README: `php php-cs-fixer readme > README.rst` (Windows `php.exe php-cs-fixer readme > README.rst`). Do not modify `README.rst` manually!
1717
* Check if tests pass: `vendor/bin/phpunit`.
1818
* Fix project itself: `php php-cs-fixer fix`.
1919

0 commit comments

Comments
 (0)