minor #4595 Import cannot be used after :: so can be removed (SpacePossum)

This PR was merged into the 2.15 branch.

Discussion
----------

Import cannot be used after `::` so can be removed

closes #4582

Commits
-------

a2771a8 Import cannot be used after `::` so can be removed.

Author: keradus

src/Fixer/Import/NoUnusedImportsFixer.php

@@ -90,7 +90,7 @@ protected function applyFix(\SplFileInfo $file, Tokens $tokens)
         foreach ((new NamespacesAnalyzer())->getDeclarations($tokens) as $namespace) {
             $currentNamespaceUseDeclarations = array_filter(
                 $useDeclarations,
-                function (NamespaceUseAnalysis $useDeclaration) use ($namespace) {
+                static function (NamespaceUseAnalysis $useDeclaration) use ($namespace) {
                     return
                         $useDeclaration->getStartIndex() >= $namespace->getScopeStartIndex()
                         && $useDeclaration->getEndIndex() <= $namespace->getScopeEndIndex()
@@ -143,18 +143,20 @@ private function isImportUsed(Tokens $tokens, NamespaceAnalysis $namespace, arra
 
                 if (
                     0 === strcasecmp($shortName, $token->getContent())
-                    && !$prevMeaningfulToken->isGivenKind([T_NS_SEPARATOR, T_CONST, T_OBJECT_OPERATOR])
+                    && !$prevMeaningfulToken->isGivenKind([T_NS_SEPARATOR, T_CONST, T_OBJECT_OPERATOR, T_DOUBLE_COLON])
                 ) {
                     return true;
                 }
 
                 continue;
             }
 
-            if ($token->isComment() && Preg::match(
-                '/(?<![[:alnum:]])(?<!\\\\)'.$shortName.'(?![[:alnum:]])/i',
-                $token->getContent()
-            )) {
+            if ($token->isComment()
+                && Preg::match(
+                    '/(?<![[:alnum:]])(?<!\\\\)'.$shortName.'(?![[:alnum:]])/i',
+                    $token->getContent()
+                )
+            ) {
                 return true;
             }
         }

tests/Fixer/Import/NoUnusedImportsFixerTest.php

@@ -506,12 +506,15 @@ public function __construct(SomeEntityRepository $repo)
 EOF
                 ,
             ],
-            'property_name' => [
+            'property name, method name, static method call, static property' => [
                 <<<'EOF'
 <?php
 
 
 $foo->bar = null;
+$foo->bar();
+$foo::bar();
+$foo::bar;
 EOF
                 ,
                 <<<'EOF'
@@ -520,6 +523,9 @@ public function __construct(SomeEntityRepository $repo)
 use Foo\Bar;
 
 $foo->bar = null;
+$foo->bar();
+$foo::bar();
+$foo::bar;
 EOF
                 ,
             ],