Fix failing validation on trezor login (#2740)

* fix pwd validation fail on hidden wallet

* fix default pass & ensure auto active coins register

* use secure random password

* refactor: migrate password generation to SDK

---------

Co-authored-by: CharlVS <[email protected]>

Author: smk762

lib/bloc/trezor_init_bloc/trezor_init_bloc.dart

@@ -1,10 +1,11 @@
 import 'dart:async';
-
 import 'package:easy_localization/easy_localization.dart';
 import 'package:equatable/equatable.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:komodo_defi_sdk/komodo_defi_sdk.dart';
 import 'package:komodo_defi_types/komodo_defi_types.dart';
+import 'package:web_dex/app_config/app_config.dart';
+import 'package:web_dex/shared/utils/password.dart';
 import 'package:web_dex/bloc/coins_bloc/coins_repo.dart';
 import 'package:web_dex/bloc/trezor_bloc/trezor_repo.dart';
 import 'package:web_dex/generated/codegen_loader.g.dart';
@@ -200,6 +201,7 @@ class TrezorInitBloc extends Bloc<TrezorInitEvent, TrezorInitState> {
       // ignore
     }
     _trezorRepo.subscribeOnConnectionStatus(deviceDetails.pubKey);
+    await _kdfSdk.addActivatedCoins(enabledByDefaultTrezorCoins);
     emit(
       state.copyWith(
         inProgress: () => false,
@@ -273,8 +275,9 @@ class TrezorInitBloc extends Bloc<TrezorInitEvent, TrezorInitState> {
   /// into a static 'hidden' wallet to init trezor
   Future<void> _loginToTrezorWallet({
     String walletName = 'My Trezor',
-    String password = 'hidden-login',
+    String? password
   }) async {
+    password ??= generatePassword();
     final bool mm2SignedIn = await _kdfSdk.auth.isSignedIn();
     if (state.kdfUser != null && mm2SignedIn) {
       return;

lib/shared/utils/password.dart

@@ -1,84 +1,9 @@
-import 'dart:math';
+import 'package:komodo_defi_types/komodo_defi_type_utils.dart';
 
-String generatePassword() {
-  final List<String> passwords = [];
-
-  final rng = Random.secure();
-
-  const String lowerCase = 'abcdefghijklmnopqrstuvwxyz';
-  const String upperCase = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ';
-  const String digit = '0123456789';
-  const String punctuation = '*.!@#\$%^(){}:;\',.?/~`_+\\-=|';
-
-  final string = [lowerCase, upperCase, digit, punctuation];
-
-  final length = rng.nextInt(24) + 8;
-
-  final List<String> tab = [];
-
-  while (true) {
-    // This loop make sure the new RPC password will contains all the requirement
-    // characters type in password, it generate automatically the position.
-    tab.clear();
-    for (var x = 0; x < length; x++) {
-      tab.add(string[rng.nextInt(4)]);
-    }
-
-    if (tab.contains(lowerCase) &&
-        tab.contains(upperCase) &&
-        tab.contains(digit) &&
-        tab.contains(punctuation)) {
-      break;
-    }
-  }
-
-  for (int i = 0; i < tab.length; i++) {
-    // Here we constitute new RPC password, and check the repetition.
-    final chars = tab[i];
-    final character = chars[rng.nextInt(chars.length)];
-    final count = passwords.where((c) => c == character).toList().length;
-    if (count < 2) {
-      passwords.add(character);
-    } else {
-      tab.add(chars);
-    }
-  }
-
-  return passwords.join('');
-}
+/// Generates a password that meets the KDF password policy requirements using
+/// the device's secure random number generator.
+String generatePassword() => SecurityUtils.generatePasswordSecure(16);
 
 /// unit tests: [testValidateRPCPassword]
-bool validateRPCPassword(String src) {
-  if (src.isEmpty) return false;
-
-  // Password can't contain word 'password'
-  if (src.toLowerCase().contains('password')) return false;
-
-  // Password must contain one digit, one lowercase letter, one uppercase letter,
-  // one special character and its length must be between 8 and 32 characters
-  final RegExp exp = RegExp(
-    r'^(?:(?=.*[0-9])(?=.*[a-z])(?=.*[A-Z])(?=.*[^A-Za-z0-9])).{8,32}$',
-  );
-  if (!src.contains(exp)) return false;
-
-  // Password can't contain same character three time in a row,
-  // so some code below to check that:
-
-  // MRC: Divide the password into all possible 3 character blocks
-  final pieces = <String>[];
-  for (int start = 0, end = 3; end <= src.length; start += 1, end += 1) {
-    pieces.add(src.substring(start, end));
-  }
-
-  // If, for any block, all 3 character are the same, block doesn't fit criteria
-  for (String p in pieces) {
-    final src = p[0];
-    int count = 1;
-    if (p[1] == src) count += 1;
-    if (p[2] == src) count += 1;
-
-    if (count == 3) return false;
-  }
-
-  return true;
-}
+bool validateRPCPassword(String src) =>
+    SecurityUtils.checkPasswordRequirements(src).isValid;