Skip to content

Conversation

@DeckerSU
Copy link
Contributor

image

This PR adds the current Git commit hash to the “Settings › General” screen in the app. The commit hash is displayed alongside the existing app version and API version, allowing developers and QA to quickly identify exactly which source revision a given build was produced from.

DeckerSU added 2 commits June 18, 2025 17:21
```
GIT_COMMIT=$(git rev-parse --short HEAD)
flutter build ... --dart-define=GIT_COMMIT=$GIT_COMMIT ...
```
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 18, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jun 18, 2025

Visit the preview URL for this PR (updated for commit 6acf7e1):

https://walletrc--pull-2796-merge-t9hlz733.web.app

(expires Wed, 25 Jun 2025 22:39:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

Copy link
Collaborator

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a good idea. Please also update the references for COMMIT_HASH to your new GIT_COMMIT.

@DeckerSU
Copy link
Contributor Author

I replaced all references to GIT_COMMIT with COMMIT_HASH, as COMMIT_HASH sounds clearer in my opinion.

The only concern I have is that all the build workflows use ./.github/actions/generate-assets to fetch packages and generate assets. That means flutter build ... is invoked once during asset generation and then again during the actual build step.

I’m thinking it might not be necessary to modify the build_command in the matrix with --dart-define=COMMIT_HASH="$COMMIT_HASH" since COMMIT_HASH is already defined in the generate-assets action [here](https://github.com/KomodoPlatform/komodo-wallet/blob/b4d012e1ff1c8a13845197e428ca35e1e6d71a35/.github/actions/generate-assets/action.yml#L76).

With the current setup, we might end up with two --dart-define=COMMIT_HASH values, like:

flutter build --dart-define=COMMIT_HASH="$COMMIT_HASH" --dart-define=COMMIT_HASH="$COMMIT_HASH"

First from the matrix command and second from generate-assets. Then again in the actual build:

flutter build --dart-define=COMMIT_HASH="$COMMIT_HASH"

I think I should fix that to avoid redundant or conflicting defines.

@DeckerSU
Copy link
Contributor Author

DeckerSU commented Jun 18, 2025

Looks like it works now. But until now, our generate_assets action has always run:

COMMIT_HASH=$(git rev-parse --short HEAD)

right after checkout. On a pull_request trigger, GitHub performs a “merge-commit” of the PR branch into the base branch, so HEAD actually pointed at that synthetic merge commit—not at the real tip of the feature branch.

Will change that behavior ...

@DeckerSU
Copy link
Contributor Author

It looks like everything is working fine now. In the preview, it correctly shows the actual commit of the PR HEAD, as expected, instead of the hash of the synthetic merge commit.

@smk762 smk762 self-requested a review June 20, 2025 05:52
Copy link
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a very useful feature for QA which came in handy on legacy desktop. Related issue added to expand on this one #2803

Copy link
Collaborator

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@CharlVS CharlVS merged commit 75d8098 into dev Jun 20, 2025
10 of 14 checks passed
@CharlVS CharlVS deleted the patch-show-commit-version branch June 20, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants