-
Notifications
You must be signed in to change notification settings - Fork 240
Show Git Commit Hash on Settings › General Page #2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
``` GIT_COMMIT=$(git rev-parse --short HEAD) flutter build ... --dart-define=GIT_COMMIT=$GIT_COMMIT ... ```
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 6acf7e1): https://walletrc--pull-2796-merge-t9hlz733.web.app (expires Wed, 25 Jun 2025 22:39:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
CharlVS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is a good idea. Please also update the references for COMMIT_HASH to your new GIT_COMMIT.
|
I replaced all references to The only concern I have is that all the build workflows use I’m thinking it might not be necessary to modify the With the current setup, we might end up with two First from the matrix command and second from I think I should fix that to avoid redundant or conflicting defines. |
as everything seems already done in generate-assets action
|
Looks like it works now. But until now, our right after checkout. On a Will change that behavior ... |
|
It looks like everything is working fine now. In the preview, it correctly shows the actual commit of the PR HEAD, as expected, instead of the hash of the synthetic merge commit. |
smk762
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a very useful feature for QA which came in handy on legacy desktop. Related issue added to expand on this one #2803
CharlVS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
This PR adds the current Git commit hash to the “Settings › General” screen in the app. The commit hash is displayed alongside the existing app version and API version, allowing developers and QA to quickly identify exactly which source revision a given build was produced from.