-
Notifications
You must be signed in to change notification settings - Fork 240
feat(ui): reclaim vertical space in assets list #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): reclaim vertical space in assets list #2810
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 45a8613): https://walletrc--pull-2810-merge-tr7vsvsw.web.app (expires Tue, 15 Jul 2025 21:11:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
e74731b to
7d7fae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reclaims vertical space in the assets list by introducing collapsible UI sections, improving scroll handling, and refactoring tab content rendering on the wallet page.
- Added
collapseProgresstoWalletManageSectionfor desktop collapsibility - Implemented custom pointer‐signal scroll handling and analytics logging
- Refactored tab slivers into
_buildTabSliversand introduced a pinnedSliverTabBarDelegate
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/views/wallet/wallet_page/wallet_main/wallet_manage_section.dart | Introduces collapseProgress, removes redundant import, and refactors desktop layout to support collapsible headers |
| lib/views/wallet/wallet_page/wallet_main/wallet_main.dart | Adds _activeTabIndex, _onPointerSignal, refactors slivers via _buildTabSlivers, and adds _SliverTabBarDelegate for a pinned tab bar |
Comments suppressed due to low confidence (2)
lib/views/wallet/wallet_page/wallet_main/wallet_manage_section.dart:21
- The
collapseProgressconstructor parameter should include a doc comment explaining its expected range (0.0–1.0) and how it affects the layout.
this.collapseProgress = 0.0,
lib/views/wallet/wallet_page/wallet_main/wallet_main.dart:499
- [nitpick] Comparing
TabBarinstances inshouldRebuildmay cause unnecessary rebuilds if the object identity changes; consider comparing only the properties that affect rendering or returning true if always updating.
return tabBar != oldDelegate.tabBar;
lib/views/wallet/wallet_page/wallet_main/wallet_manage_section.dart
Outdated
Show resolved
Hide resolved
…ithub.com/KomodoPlatform/komodo-wallet into codex/consolidate-wallet-page-into-scrollable-sliver
- Redesign StatisticCard component with simplified, cleaner appearance: - Remove gradient background and large action icons - Add trend indicators in top-right corner - Improve dark mode contrast with pure black backgrounds - Reduce visual clutter for better readability - Enhance financial displays to show both percentage and USD value changes - Update wallet overview cards to display 24h change amounts alongside percentages - Improve TrendPercentageText to support value formatting for monetary displays - Migrate UI components to komodo_ui_kit package for consistency BREAKING CHANGE: StatisticCard API changed - 'footer' and 'actionIcon' props replaced with 'trendWidget' and 'actionWidget' for more flexible layouts
* feat(wallet): use widget for floating button * feat(ui): mobile assets list view rework
…consolidate-wallet-page-into-scrollable-sliver
…-sliver # Conflicts: # lib/bloc/auth_bloc/auth_bloc.dart # lib/bloc/auth_bloc/auth_bloc_event.dart # lib/views/bridge/bridge_ticker_selector.dart # lib/views/bridge/bridge_tickers_list_item.dart # lib/views/common/hw_wallet_dialog/trezor_steps/trezor_dialog_error.dart # lib/views/wallet/wallet_page/common/asset_list_item_desktop.dart # lib/views/wallet/wallet_page/common/grouped_asset_ticker_item.dart # lib/views/wallet/wallet_page/wallet_main/wallet_manage_section.dart # lib/views/wallet/wallet_page/wallet_main/wallet_overview.dart # macos/Flutter/GeneratedPluginRegistrant.swift # packages/komodo_ui_kit/pubspec.lock # pubspec.lock
Reclaim vertical design in mobile and desktop layouts in asset lists.