Skip to content

Conversation

@ca333
Copy link
Contributor

@ca333 ca333 commented Oct 29, 2025

add robust normalization utilities

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix_decimals

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ca333 ca333 merged commit ebb3f74 into dev Oct 29, 2025
6 of 12 checks passed
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Visit the preview URL for this PR (updated for commit 5252473):

https://walletrc--pull-3297-merge-7hhk7a1v.web.app

(expires Wed, 05 Nov 2025 14:15:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +402 to +406
normalized = normalized
.replaceAll(' ', '')
.replaceAll('\u00A0', '') // NBSP
.replaceAll('\u202F', '') // NNBSP
.replaceAll("'", '')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge NBSP separators not stripped during normalization

The new normalizeDecimalString tries to remove non‑breaking spaces (U+00A0) and narrow no‑break spaces (U+202F) before parsing, but the literals passed to replaceAll are '\u00A0' and '\u202F'. Those are two-character sequences (backslash + u…) rather than the actual Unicode whitespace characters, so real NBSPs remain in the string and the subsequent regex fails. Inputs copied from locales that use NBSP as the thousands separator (e.g. French 1 234,56) will still throw FormatException despite the tests claiming support. Use ' ' and ' ' to strip the intended characters.

Useful? React with 👍 / 👎.

@ca333 ca333 mentioned this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants