Skip to content

Conversation

@onur-ozkan
Copy link
Collaborator

@onur-ozkan onur-ozkan commented Dec 6, 2023

Changes made to not allow using 7777 netid.

Should be considered as a blocker for #1968

@onur-ozkan onur-ozkan force-pushed the cut-deprecated-network-communications branch from 07b952d to 8b179d8 Compare December 6, 2023 13:15
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Only one question.

Signed-off-by: onur-ozkan <[email protected]>
@onur-ozkan onur-ozkan force-pushed the cut-deprecated-network-communications branch from 8b179d8 to 41aca51 Compare December 6, 2023 21:15
@onur-ozkan onur-ozkan changed the title feat(network): cut deprecated network communications feat(network): deprecate 7777 network Dec 6, 2023
@shamardy shamardy merged commit efa2426 into dev Dec 6, 2023
@shamardy shamardy deleted the cut-deprecated-network-communications branch December 6, 2023 22:24
dimxy pushed a commit to dimxy/komodo-defi-framework that referenced this pull request Dec 21, 2023
* dev: (22 commits)
  chore(config): remove vscode launchjson (GLEECBTC#2040)
  feat(trading-proto-upgrade): wasm DB, kickstart, refund states, v2 RPCs (GLEECBTC#2015)
  feat(UTXO): balance event streaming for Electrum clients (GLEECBTC#2013)
  feat(tx): add new sign_raw_transaction rpc for UTXO and EVM coins (GLEECBTC#1930)
  fix(p2p): handle encode_and_sign errors (GLEECBTC#2038)
  chore(release): add changelog entries for v2.0.0-beta (GLEECBTC#2037)
  chore(network): write network information to stdout (GLEECBTC#2034)
  fix(price_endpoints): add cached url (GLEECBTC#2032)
  deps(network): sync with upstream yamux (GLEECBTC#2030)
  fix(config): accept a string as rpcport value (GLEECBTC#2026)
  feat(nft): move db lock, add tx fee and confirmations (GLEECBTC#1989)
  chore(network): update seednodes for netid 8762 (GLEECBTC#2024)
  chore(network): add todo on peer storage behaviour (GLEECBTC#2025)
  chore(network): exclude `168.119.236.249` from the seednode list (GLEECBTC#2021)
  feat(network): deprecate 7777 network (GLEECBTC#2020)
  chore(release): bump mm2 version to 2.0.0-beta (GLEECBTC#2018)
  feat(UTXO swaps): kmd burn plan impl (GLEECBTC#2006)
  chore(docs): fix the link to simple market maker in README.md (GLEECBTC#2011)
  refactor(cli): cli dependency updates and warn on bad config perm (GLEECBTC#1956)
  chore(containers and docs): update docs and container images (GLEECBTC#2003)
  ...

# Conflicts:
#	mm2src/mm2_main/tests/mm2_tests/mm2_tests_inner.rs
#	mm2src/mm2_test_helpers/src/for_tests.rs
dimxy pushed a commit to dimxy/komodo-defi-framework that referenced this pull request Jan 23, 2024
* dev: (24 commits)
  chore(release): bump mm2 version to 2.1.0-beta (GLEECBTC#2044)
  feat(trezor): add segwit support for withdraw with trezor (GLEECBTC#1984)
  chore(config): remove vscode launchjson (GLEECBTC#2040)
  feat(trading-proto-upgrade): wasm DB, kickstart, refund states, v2 RPCs (GLEECBTC#2015)
  feat(UTXO): balance event streaming for Electrum clients (GLEECBTC#2013)
  feat(tx): add new sign_raw_transaction rpc for UTXO and EVM coins (GLEECBTC#1930)
  fix(p2p): handle encode_and_sign errors (GLEECBTC#2038)
  chore(release): add changelog entries for v2.0.0-beta (GLEECBTC#2037)
  chore(network): write network information to stdout (GLEECBTC#2034)
  fix(price_endpoints): add cached url (GLEECBTC#2032)
  deps(network): sync with upstream yamux (GLEECBTC#2030)
  fix(config): accept a string as rpcport value (GLEECBTC#2026)
  feat(nft): move db lock, add tx fee and confirmations (GLEECBTC#1989)
  chore(network): update seednodes for netid 8762 (GLEECBTC#2024)
  chore(network): add todo on peer storage behaviour (GLEECBTC#2025)
  chore(network): exclude `168.119.236.249` from the seednode list (GLEECBTC#2021)
  feat(network): deprecate 7777 network (GLEECBTC#2020)
  chore(release): bump mm2 version to 2.0.0-beta (GLEECBTC#2018)
  feat(UTXO swaps): kmd burn plan impl (GLEECBTC#2006)
  chore(docs): fix the link to simple market maker in README.md (GLEECBTC#2011)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants