fix(tendermint): fee calculation #2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
May 9, 2024
* dev: feat(app-dir): implement root application dir `.kdf` (GLEECBTC#2102) fix tendermint fee calculation (GLEECBTC#2106) update dockerfile (GLEECBTC#2104) docs(README): remove outdated information from the README (GLEECBTC#2097) fix(sia): fix sia compilation after hd wallet PR merge (GLEECBTC#2103) feat(hd_wallet): utxo and evm hd wallet and trezor (GLEECBTC#1962) feat(sia): initial Sia integration (GLEECBTC#2086) fix(BCH): deserialize BCH header that uses KAWPOW version correctly (GLEECBTC#2099) fix(eth_tests): remove ETH_DEV_NODE from tests (GLEECBTC#2101) feat(coin): support nucleus as an alternative to iris HTLC (GLEECBTC#2079)
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
May 14, 2024
* dev: feat(tendermint): pubkey-only activation and unsigned tx (GLEECBTC#2088) fix(tests): set txfee for some tbtc tests (GLEECBTC#2116) fix(eth): remove my_address from sign_and_send_transaction_with_keypair (GLEECBTC#2115) fix(utxo-swap): apply events occurred while taker down (GLEECBTC#2114) refactor(memory): memory usage improvements (GLEECBTC#2098) feat(app-dir): implement root application dir `.kdf` (GLEECBTC#2102) fix tendermint fee calculation (GLEECBTC#2106) update dockerfile (GLEECBTC#2104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As makers may not have a balance in the coin they want to swap, we need to calculate
get_receiver_trade_feein platform coin.Same goes for ETH assets: https://github.com/KomodoPlatform/komodo-defi-framework/blob/b0fd99e8406e67ea06435dd028991caa5f522b5c/mm2src/coins/eth.rs#L4892-L4895