Skip to content

fix(binance): use the per-coin supported quote currency list instead of the global cache #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CharlVS merged 3 commits into from
Sep 18, 2025
Merged

fix(binance): use the per-coin supported quote currency list instead of the global cache #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c56989
fix(binance-repo): use coin-specific fiat currency list for supports
takenagain Sep 17, 2025
bfe5093
feat(binance-repo): add alternative USD stablecoin mappings
takenagain Sep 17, 2025
05a97cf
refactor(binance): remove unused fiat cache and address nitpicks
takenagain Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
210 changes: 179 additions & 31 deletions packages/komodo_cex_market_data/lib/src/binance/data/binance_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import 'package:async/async.dart';
import 'package:decimal/decimal.dart';
import 'package:komodo_cex_market_data/komodo_cex_market_data.dart';
import 'package:komodo_cex_market_data/src/binance/models/binance_exchange_info_reduced.dart';
import 'package:komodo_defi_types/komodo_defi_types.dart';
import 'package:logging/logging.dart';

Expand Down Expand Up @@ -35,8 +34,28 @@ class BinanceRepository implements CexRepository {

static final Logger _logger = Logger('BinanceRepository');

/// Priority order of USD stablecoins for fallback selection
/// Ordered from most liquid/preferred to least preferred
static const List<String> _usdStablecoinPriority = [
'USDT', // Tether - most liquid
'USDC', // USD Coin - most regulated
'BUSD', // Binance USD - native to Binance
'FDUSD', // First Digital USD
'TUSD', // TrueUSD
'USDP', // Pax Dollar
'DAI', // MakerDAO DAI
'LUSD', // Liquity USD
'GUSD', // Gemini Dollar
'SUSD', // Synthetix USD
'FEI', // Fei USD
];

final AsyncMemoizer<List<CexCoin>> _coinListMemoizer = AsyncMemoizer();
Set<String>? _cachedFiatCurrencies;

/// Get the USD stablecoin priority configuration
/// Returns a list of USD stablecoins ordered by preference for fallback selection
static List<String> get usdStablecoinPriority =>
List.unmodifiable(_usdStablecoinPriority);

@override
Future<List<CexCoin>> getCoinList() async {
Expand All @@ -59,11 +78,7 @@ class BinanceRepository implements CexRepository {
final exchangeInfo = await _binanceProvider.fetchExchangeInfoReduced(
baseUrl: baseUrl,
);
final coinsList = _convertSymbolsToCoins(exchangeInfo);
_cachedFiatCurrencies = exchangeInfo.symbols
.map((s) => s.quoteAsset.toUpperCase())
.toSet();
return coinsList;
return _convertSymbolsToCoins(exchangeInfo);
} catch (e) {
lastException = e is Exception ? e : Exception(e.toString());
}
Expand Down Expand Up @@ -95,10 +110,29 @@ class BinanceRepository implements CexRepository {
int? limit,
}) async {
final baseTicker = resolveTradingSymbol(assetId);
final relTicker = quoteCurrency.binanceId;

if (baseTicker.toUpperCase() == relTicker.toUpperCase()) {
throw ArgumentError('Base and rel coin tickers cannot be the same');
// Find the best available quote currency for this coin
final coins = await getCoinList();
final coin = coins.firstWhere(
(c) => c.id.toUpperCase() == baseTicker.toUpperCase(),
orElse: () =>
throw ArgumentError.value(baseTicker, 'assetId', 'Asset not found'),
);

final effectiveQuote = _getEffectiveQuoteCurrency(coin, quoteCurrency);
if (effectiveQuote == null) {
throw ArgumentError(
'No suitable quote currency available for $baseTicker with '
'requested ${quoteCurrency.symbol}',
);
}

if (baseTicker.toUpperCase() == effectiveQuote.toUpperCase()) {
throw ArgumentError.value(
effectiveQuote,
'quoteCurrency',
'Base and rel coin tickers cannot be the same',
);
}

final startUnixTimestamp = startAt?.millisecondsSinceEpoch;
Expand All @@ -110,7 +144,7 @@ class BinanceRepository implements CexRepository {
for (final baseUrl in binanceApiEndpoint) {
try {
final symbolString =
'${baseTicker.toUpperCase()}${relTicker.toUpperCase()}';
'${baseTicker.toUpperCase()}${effectiveQuote.toUpperCase()}';
return await _binanceProvider.fetchKlines(
symbolString,
intervalAbbreviation,
Expand Down Expand Up @@ -143,10 +177,32 @@ class BinanceRepository implements CexRepository {
QuoteCurrency fiatCurrency = Stablecoin.usdt,
}) async {
final tradingSymbol = resolveTradingSymbol(assetId);
final fiatCurrencyId = fiatCurrency.binanceId.toLowerCase();

if (tradingSymbol.toUpperCase() == fiatCurrencyId.toUpperCase()) {
throw ArgumentError('Coin and fiat coin cannot be the same');
// Find the best available quote currency for this coin
final coins = await getCoinList();
final coin = coins.firstWhere(
(c) => c.id.toUpperCase() == tradingSymbol.toUpperCase(),
orElse: () => throw ArgumentError.value(
tradingSymbol,
'assetId',
'Asset not found',
),
);

final effectiveQuote = _getEffectiveQuoteCurrency(coin, fiatCurrency);
if (effectiveQuote == null) {
throw ArgumentError(
'No suitable quote currency available for $tradingSymbol with '
'requested ${fiatCurrency.symbol}',
);
}

if (tradingSymbol.toUpperCase() == effectiveQuote.toUpperCase()) {
throw ArgumentError.value(
effectiveQuote,
'fiatCurrency',
'Coin and fiat coin cannot be the same',
);
}

final endAt = priceDate ?? DateTime.now();
Expand All @@ -169,21 +225,42 @@ class BinanceRepository implements CexRepository {
List<DateTime> dates, {
QuoteCurrency fiatCurrency = Stablecoin.usdt,
}) async {
final tradingSymbol = resolveTradingSymbol(assetId).toLowerCase();
final fiatCurrencyId = fiatCurrency.binanceId.toLowerCase();
final tradingSymbol = resolveTradingSymbol(assetId);

// Find the best available quote currency for this coin
final coins = await getCoinList();
final coin = coins.firstWhere(
(c) => c.id.toUpperCase() == tradingSymbol.toUpperCase(),
orElse: () => throw ArgumentError.value(
tradingSymbol,
'assetId',
'Asset not found',
),
);

if (tradingSymbol == fiatCurrencyId) {
throw ArgumentError('Coin and fiat coin cannot be the same');
final effectiveQuote = _getEffectiveQuoteCurrency(coin, fiatCurrency);
if (effectiveQuote == null) {
throw ArgumentError(
'No suitable quote currency available for $tradingSymbol with '
'requested ${fiatCurrency.symbol}',
);
}

dates.sort();
if (tradingSymbol.toLowerCase() == effectiveQuote.toLowerCase()) {
throw ArgumentError.value(
effectiveQuote,
'fiatCurrency',
'Coin and fiat coin cannot be the same',
);
}

if (dates.isEmpty) {
return {};
}

final startDate = dates.first.add(const Duration(days: -2));
final endDate = dates.last.add(const Duration(days: 2));
final sortedDates = List.of(dates)..sort();
final startDate = sortedDates.first.add(const Duration(days: -2));
final endDate = sortedDates.last.add(const Duration(days: 2));
final daysDiff = endDate.difference(startDate).inDays;

final result = <DateTime, Decimal>{};
Expand Down Expand Up @@ -227,15 +304,36 @@ class BinanceRepository implements CexRepository {
QuoteCurrency fiatCurrency = Stablecoin.usdt,
}) async {
final tradingSymbol = resolveTradingSymbol(assetId);
final fiatCurrencyId = fiatCurrency.binanceId.toLowerCase();

if (tradingSymbol.toUpperCase() == fiatCurrencyId.toUpperCase()) {
throw ArgumentError('Coin and fiat coin cannot be the same');
// Find the best available quote currency for this coin
final coins = await getCoinList();
final coin = coins.firstWhere(
(c) => c.id.toUpperCase() == tradingSymbol.toUpperCase(),
orElse: () => throw ArgumentError.value(
tradingSymbol,
'assetId',
'Asset not found',
),
);

final effectiveQuote = _getEffectiveQuoteCurrency(coin, fiatCurrency);
if (effectiveQuote == null) {
throw ArgumentError(
'No suitable quote currency available for $tradingSymbol with '
'requested ${fiatCurrency.symbol}',
);
}

if (tradingSymbol.toUpperCase() == effectiveQuote.toUpperCase()) {
throw ArgumentError.value(
effectiveQuote,
'fiatCurrency',
'Coin and fiat coin cannot be the same',
);
}

final trimmedCoinId = tradingSymbol.replaceAll(RegExp('-segwit'), '');
final symbol =
'${trimmedCoinId.toUpperCase()}${fiatCurrencyId.toUpperCase()}';
'${tradingSymbol.toUpperCase()}${effectiveQuote.toUpperCase()}';

// Try primary endpoint first, fallback to secondary on failure
Exception? lastException;
Expand Down Expand Up @@ -279,6 +377,49 @@ class BinanceRepository implements CexRepository {
return coins.values.toList();
}

/// Find the best available USD stablecoin for a specific coin
/// Returns null if no USD stablecoins are available for this coin
String? _findBestUsdStablecoinForCoin(CexCoin coin) {
for (final stablecoin in _usdStablecoinPriority) {
if (coin.currencies.contains(stablecoin)) {
return stablecoin;
}
}
return null;
}

/// Get the effective quote currency for a coin, with fallback logic
/// For USD/USDT requests, tries to find the best available USD stablecoin
String? _getEffectiveQuoteCurrency(
CexCoin coin,
QuoteCurrency quoteCurrency,
) {
final originalQuote = quoteCurrency.binanceId.toUpperCase();

// If the coin directly supports the requested quote currency, use it
if (coin.currencies.contains(originalQuote)) {
return originalQuote;
}

// Special handling for USD and USD stablecoins
final isUsdRequest =
quoteCurrency.symbol.toUpperCase() == 'USD' ||
(quoteCurrency.isStablecoin &&
quoteCurrency.maybeWhen(
stablecoin: (_, __, underlying) =>
underlying.symbol.toUpperCase() == 'USD',
orElse: () => false,
));

if (isUsdRequest) {
// Try to find any available USD stablecoin for this coin
return _findBestUsdStablecoinForCoin(coin);
}

// For non-USD currencies, no fallback - must have exact match
return null;
}

@override
Future<bool> supports(
AssetId assetId,
Expand All @@ -287,15 +428,22 @@ class BinanceRepository implements CexRepository {
) async {
try {
final coins = await getCoinList();
final fiat = fiatCurrency.binanceId;
// If resolveTradingSymbol throws, treat as unsupported
final tradingSymbol = resolveTradingSymbol(assetId);
final supportsAsset = coins.any(

// Find the specific coin
final coin = coins.firstWhere(
(c) => c.id.toUpperCase() == tradingSymbol.toUpperCase(),
orElse: () => throw ArgumentError.value(
tradingSymbol,
'assetId',
'Asset not found',
),
);
final supportsFiat =
_cachedFiatCurrencies?.contains(fiat.toUpperCase()) ?? false;
return supportsAsset && supportsFiat;

// Check if we can find an effective quote currency for this coin
final effectiveQuote = _getEffectiveQuoteCurrency(coin, fiatCurrency);
return effectiveQuote != null;
} on ArgumentError {
return false;
}
Expand Down
1 change: 0 additions & 1 deletion packages/komodo_cex_market_data/lib/src/coingecko/data/coingecko_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import 'package:async/async.dart';
import 'package:decimal/decimal.dart';
import 'package:komodo_cex_market_data/src/cex_repository.dart';
import 'package:komodo_cex_market_data/src/coingecko/_coingecko_index.dart';
import 'package:komodo_cex_market_data/src/coingecko/models/coin_historical_data/coin_historical_data.dart';
import 'package:komodo_cex_market_data/src/id_resolution_strategy.dart';
import 'package:komodo_cex_market_data/src/models/_models_index.dart';
import 'package:komodo_cex_market_data/src/repository_selection_strategy.dart';
Expand Down
Loading
Loading