Fix character affiliation method,#15
Merged
0xf0xx0 merged 1 commit into0xf0xx0:masterfrom Oct 31, 2020
Merged
Conversation
….0.1. The param name now matches the variables inside the function again, and the function comment + character.md doc are updated to mirror the ESI and more clearly describe what the method does.
Owner
|
Whoops, looks like i broke something, thanks for catching it :D |
Contributor
Author
|
Happy to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which broke from version 3.0.2 to 4.0.1. The param name now matches the variables inside the function again, and the function comment + character.md doc are updated to mirror the ESI and more clearly describe what the method does.
I tried to mirror the style of esiJS as closely as possible, hopefully the changes are up to snuff.