fixed code review recommendations

Author: arturcic

src/GitVersion.Core/VersionCalculation/VariableProvider.cs

@@ -39,34 +39,35 @@ public GitVersionVariables GetVariablesFor(
             "AssemblyVersioningFormat"
         );
 
-        return new(assemblyFileSemVer,
-            assemblySemVer,
-            semverFormatValues.BranchName,
-            semverFormatValues.BuildMetaData,
-            semverFormatValues.CommitDate,
-            semverFormatValues.VersionSourceDistance,
-            semverFormatValues.EscapedBranchName,
-            semverFormatValues.FullBuildMetaData,
-            semverFormatValues.FullSemVer,
-            informationalVersion,
-            semverFormatValues.Major,
-            semverFormatValues.MajorMinorPatch,
-            semverFormatValues.Minor,
-            semverFormatValues.Patch,
-            semverFormatValues.PreReleaseLabel,
-            semverFormatValues.PreReleaseLabelWithDash,
-            semverFormatValues.PreReleaseNumber,
-            semverFormatValues.PreReleaseTag,
-            semverFormatValues.PreReleaseTagWithDash,
-            semverFormatValues.SemVer,
-            semverFormatValues.Sha,
-            semverFormatValues.ShortSha,
-            semverFormatValues.UncommittedChanges,
-            semverFormatValues.VersionSourceDistance,
-            semverFormatValues.VersionSourceIncrement,
-            semverFormatValues.VersionSourceSemVer,
-            semverFormatValues.VersionSourceSha,
-            semverFormatValues.WeightedPreReleaseNumber);
+        return new(
+            AssemblySemFileVer: assemblyFileSemVer,
+            AssemblySemVer: assemblySemVer,
+            BranchName: semverFormatValues.BranchName,
+            BuildMetaData: semverFormatValues.BuildMetaData,
+            CommitDate: semverFormatValues.CommitDate,
+            CommitsSinceVersionSource: semverFormatValues.VersionSourceDistance,
+            EscapedBranchName: semverFormatValues.EscapedBranchName,
+            FullBuildMetaData: semverFormatValues.FullBuildMetaData,
+            FullSemVer: semverFormatValues.FullSemVer,
+            InformationalVersion: informationalVersion,
+            Major: semverFormatValues.Major,
+            MajorMinorPatch: semverFormatValues.MajorMinorPatch,
+            Minor: semverFormatValues.Minor,
+            Patch: semverFormatValues.Patch,
+            PreReleaseLabel: semverFormatValues.PreReleaseLabel,
+            PreReleaseLabelWithDash: semverFormatValues.PreReleaseLabelWithDash,
+            PreReleaseNumber: semverFormatValues.PreReleaseNumber,
+            PreReleaseTag: semverFormatValues.PreReleaseTag,
+            PreReleaseTagWithDash: semverFormatValues.PreReleaseTagWithDash,
+            SemVer: semverFormatValues.SemVer,
+            Sha: semverFormatValues.Sha,
+            ShortSha: semverFormatValues.ShortSha,
+            UncommittedChanges: semverFormatValues.UncommittedChanges,
+            VersionSourceDistance: semverFormatValues.VersionSourceDistance,
+            VersionSourceIncrement: semverFormatValues.VersionSourceIncrement,
+            VersionSourceSemVer: semverFormatValues.VersionSourceSemVer,
+            VersionSourceSha: semverFormatValues.VersionSourceSha,
+            WeightedPreReleaseNumber: semverFormatValues.WeightedPreReleaseNumber);
     }
 
     private string? CheckAndFormatString<T>(string? formatString, T source, string? defaultValue, string formatVarName)
@@ -82,7 +83,7 @@ public GitVersionVariables GetVariablesFor(
             try
             {
                 formattedString = formatString.FormatWith(source, this.environment)
-                                              .RegexReplace(RegexPatterns.Output.SanitizeAssemblyInfoRegexPattern, "-");
+                    .RegexReplace(RegexPatterns.Output.SanitizeAssemblyInfoRegexPattern, "-");
             }
             catch (ArgumentException exception)
             {

src/GitVersion.Core/VersionCalculation/VersionCalculators/NextVersionCalculator.cs

@@ -240,7 +240,9 @@ private List<NextVersion> GetNextVersions(IBranch branch, IGitVersionConfigurati
         using (log.IndentLog("Fetching the base versions for version calculation..."))
         {
             if (branch.Tip == null)
+            {
                 throw new GitVersionException("No commits found on the current branch.");
+            }
 
             return [.. GetNextVersionsInternal()];
         }