Merge pull request #21135 from Homebrew/sorbet-equals

Update type signature for `==`

Author: MikeMcQuaid

Library/Homebrew/bump_version_parser.rb

@@ -51,11 +51,14 @@ def blank?
       @general.blank? && @arm.blank? && @intel.blank?
     end
 
-    sig { params(other: T.untyped).returns(T::Boolean) }
+    sig { params(other: T.anything).returns(T::Boolean) }
     def ==(other)
-      return false unless other.is_a?(BumpVersionParser)
-
-      (general == other.general) && (arm == other.arm) && (intel == other.intel)
+      case other
+      when BumpVersionParser
+        (general == other.general) && (arm == other.arm) && (intel == other.intel)
+      else
+        false
+      end
     end
   end
 end

Library/Homebrew/checksum.rb

@@ -20,7 +20,7 @@ def inspect
 
   delegate [:empty?, :to_s, :length, :[]] => :@hexdigest
 
-  sig { params(other: T.any(String, Checksum, Symbol)).returns(T::Boolean) }
+  sig { params(other: T.anything).returns(T::Boolean) }
   def ==(other)
     case other
     when String

Library/Homebrew/utils/pypi.rb

@@ -129,9 +129,14 @@ def same_package?(other)
     end
 
     # Compare only names so we can use .include? and .uniq on a Package array
-    sig { params(other: Package).returns(T::Boolean) }
+    sig { params(other: T.anything).returns(T::Boolean) }
     def ==(other)
-      same_package?(other)
+      case other
+      when Package
+        same_package?(other)
+      else
+        false
+      end
     end
     alias eql? ==
 

Library/Homebrew/version.rb

@@ -633,7 +633,7 @@ def <=>(other)
     0
   end
 
-  sig { override.params(other: T.untyped).returns(T::Boolean) }
+  sig { override.params(other: T.anything).returns(T::Boolean) }
   def ==(other)
     # Makes sure that the same instance of Version::NULL
     # will never equal itself; normally Comparable#==