Skip to content

test_bot: more fixes for building portable Ruby. #20783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeMcQuaid merged 1 commit into from
Sep 30, 2025
Merged

test_bot: more fixes for building portable Ruby. #20783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions Library/Homebrew/test_bot/formulae.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ def run!(args:)
verify_local_bottles

with_env(HOMEBREW_DISABLE_LOAD_FORMULA: "1") do
# Portable Ruby bottles are rebuilt every time.
next if tap&.core_tap? && @testing_formulae.include?("portable-ruby")
# Portable Ruby bottles are handled differently.
next if testing_portable_ruby?

# TODO: move to extend/os
# rubocop:todo Homebrew/MoveToExtendOS
Expand Down Expand Up @@ -198,6 +198,9 @@ def cleanup_bottle_etc_var(formula)
end

def verify_local_bottles
# Portable Ruby bottles are handled differently.
return if testing_portable_ruby?

# Setting `HOMEBREW_DISABLE_LOAD_FORMULA` probably doesn't do anything here but let's set it just to be safe.
with_env(HOMEBREW_DISABLE_LOAD_FORMULA: "1") do
missing_bottles = @bottle_checksums.keys.reject do |bottle_path|
Expand Down Expand Up @@ -404,10 +407,11 @@ def formula!(formula_name, args:)
return
end

if tap&.core_tap? && formula.name == "portable-ruby"
# TODO: resolve [email protected] attestation issues
ENV["HOMEBREW_NO_VERIFY_ATTESTATIONS"] = "1"
test "brew", "portable-package", "portable-ruby"
if testing_portable_ruby?
test "brew", "portable-package", "portable-ruby",
# TODO: resolve [email protected] attestation issues
env: { "HOMEBREW_NO_VERIFY_ATTESTATIONS" => "1" },
verbose: true
return
end

Expand Down Expand Up @@ -635,6 +639,10 @@ def deleted_formula!(formula_name)
"--include-test",
formula_name
end

def testing_portable_ruby?
tap&.core_tap? && @testing_formulae.include?("portable-ruby")
end
end
end
end
Loading