Skip to content

Conversation

@chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Oct 19, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This aligns with what we are doing in homebrew-core.

Copilot AI review requested due to automatic review settings October 19, 2025 01:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation and test examples to reflect the replacement of pkg-config with pkgconf as the preferred package configuration tool in Homebrew formulas.

  • Updated Formula Cookbook documentation to use pkgconf instead of pkg-config in examples
  • Updated RuboCop test fixtures to use pkgconf for consistency
  • Modified naming guidelines to reference pkgconf as the canonical example

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/Formula-Cookbook.md Updated three example code blocks and naming guidelines to reference pkgconf instead of pkg-config
Library/Homebrew/test/rubocops/components_order_spec.rb Updated test fixture examples to use pkgconf for consistency with updated documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@p-linnane p-linnane added this pull request to the merge queue Oct 19, 2025
Merged via the queue into main with commit e298de3 Oct 19, 2025
37 checks passed
@p-linnane p-linnane deleted the formulae-pkgconf branch October 19, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants