Skip to content

Conversation

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Oct 23, 2025

We're going to deprecate this in 4.7.0 (#20755) so let's hide it from the man page, completions and other documentation until then.

We're going to deprecate this in 4.7.0 so let's hide it from the man
page, completions and other documentation until then.
Copilot AI review requested due to automatic review settings October 23, 2025 15:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares for the deprecation of the --[no-]quarantine option by hiding it from user-facing documentation and shell completions ahead of its planned deprecation in version 4.7.0. The option is marked as hidden in the code but remains functional.

Key changes:

  • Documentation files updated to remove --[no-]quarantine references
  • Shell completion files (bash, zsh, fish) updated to exclude the quarantine options
  • Ruby command files annotated with deprecation comments and hidden: true flag

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
manpages/brew.1 Removed --[no-]quarantine option documentation from multiple commands
docs/Manpage.md Removed --[no-]quarantine option descriptions from fetch, install, reinstall, and upgrade commands
docs/FAQ.md Removed mention of --no-quarantine switch from Gatekeeper workaround instructions
completions/zsh/_brew Removed --quarantine and --no-quarantine completions from fetch, install, reinstall, and upgrade commands
completions/fish/brew.fish Removed quarantine option completions from multiple brew commands
completions/bash/brew Removed quarantine options from bash completion definitions
Library/Homebrew/env_config.rb Updated HOMEBREW_CASK_OPTS description to remove --no-quarantine reference
Library/Homebrew/cmd/upgrade.rb Added deprecation comment and hidden: true flag to quarantine switch
Library/Homebrew/cmd/reinstall.rb Added deprecation comment and hidden: true flag to quarantine switch
Library/Homebrew/cmd/install.rb Added deprecation comment and hidden: true flag to quarantine switch
Library/Homebrew/cmd/fetch.rb Added deprecation comment and hidden: true flag to quarantine switch

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@p-linnane p-linnane added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit 1e6e400 Oct 23, 2025
38 checks passed
@p-linnane p-linnane deleted the hide_quarantine branch October 23, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants