Improvements to HOMEBREW_USE_INTERNAL_API
#20947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Oct 29, 2025
Rylan12
force-pushed
the
use-internal-api-improvements
branch
2 times, most recently
from
b190a96 to
f428d23
Compare
Member
Author
|
I named the helper |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors formula loading calls by introducing and using a new Formulary.factory_stub method as a cleaner API for requesting stubbed formula instances. The change replaces scattered calls to Formulary.factory(..., prefer_stub: true) with the more explicit Formulary.factory_stub(...) method.
Key changes:
- Added
Formulary.factory_stubmethod as a shortcut for callingfactorywithprefer_stub: true - Updated all call sites to use the new method instead of passing the
prefer_stubparameter - Replaced some
Formula[name]calls withFormulary.factory_stub(name)where only stub data is needed
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/formulary.rb | Added new factory_stub method with documentation and updated resolve to use it |
| Library/Homebrew/style.rb | Updated shellcheck, shfmt, and actionlint methods to use factory_stub |
| Library/Homebrew/extend/pathname.rb | Updated which_install_info to use factory_stub for texinfo formula |
| Library/Homebrew/extend/os/mac/pkgconf.rb | Updated macos_sdk_mismatch to use factory_stub for pkgconf formula |
| Library/Homebrew/extend/kernel.rb | Updated ensure_executable! to use factory_stub |
| Library/Homebrew/cli/parser.rb | Updated formulae method to use factory_stub |
| Library/Homebrew/cli/named_args.rb | Updated load_formula_or_cask to use factory_stub |
| Library/Homebrew/attestation.rb | Updated sort_formulae_for_install to check formula names instead of using Formula["gh"] |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rylan12
force-pushed
the
use-internal-api-improvements
branch
from
f428d23 to
f3a83f7
Compare
MikeMcQuaid
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a handful of improvements to installations with
HOMEBREW_USE_INTERNAL_APIto help reduce unnecessary downloads of formula JSON files.A note: I started working on this before #20940, and there were some conflicts, so I'm not sure they play nicely together yet.