Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Oct 31, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

These are either slow or rate limited as frequently hit failures in CI. Also upstream requested we minimize load on ftp.gnu.org so should just stop curl-ing mirror in our audit checks (we run these on every runner so at least 6 times per PR in a short time period)

We do something similar for homepage audit but that still runs on self-hosted runners:

# Skip gnu.org and nongnu.org audit on GitHub runners
# See issue: https://github.com/Homebrew/homebrew-core/issues/206757
github_runner = ENV.fetch("GITHUB_ACTIONS", nil) && !ENV["GITHUB_ACTIONS_HOMEBREW_SELF_HOSTED"]
return if homepage.match?(%r{^https?://www\.(?:non)?gnu\.org/.+}) && github_runner

Copilot AI review requested due to automatic review settings October 31, 2025 14:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an exclusion for ftp.gnu.org URLs from URL auditing in the ResourceAuditor class to address issue #20456. The change prevents the HTTP content audit from being performed on ftp.gnu.org URLs.

  • Adds a skip condition for ftp.gnu.org URLs before the HTTP content check

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid enabled auto-merge October 31, 2025 15:03
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 31, 2025
Merged via the queue into main with commit 7f2387c Oct 31, 2025
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the skip-ftp.gnu.org branch October 31, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants