Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Nov 9, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Uncomment deprecation for next release

Copilot AI review requested due to automatic review settings November 9, 2025 17:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR uncomments a deprecation warning in the EmbeddedPatch#apply method to alert users when they use the older HOMEBREW_PREFIX placeholder instead of the newer @@HOMEBREW_PREFIX@@ placeholder in patches.

Key changes:

  • Enables a previously commented-out deprecation warning for the legacy HOMEBREW_PREFIX placeholder syntax in patches

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 9, 2025
Merged via the queue into main with commit d61614b Nov 9, 2025
37 checks passed
@MikeMcQuaid MikeMcQuaid deleted the patch-deprecate branch November 9, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants