Skip to content

Conversation

@botantony
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

--write-only flag already skips PR check but it doesn't happen in check_new_version method:

check_pull_requests(formula, tap_remote_repo, state: "open") unless args.write_only?

Fixes Homebrew/discussions#6542

Copilot AI review requested due to automatic review settings November 13, 2025 15:47
Copilot finished reviewing on behalf of botantony November 13, 2025 15:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures the --write-only flag consistently skips GitHub pull request checks throughout the bump-formula-pr command. The flag is intended to make file modifications without Git/PR actions, but the check_new_version method was still performing PR duplicate checks even when this flag was set.

  • Adds conditional check to skip check_pull_requests call in check_new_version method when --write-only is used

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 48ff4a9 Nov 13, 2025
43 checks passed
@MikeMcQuaid MikeMcQuaid deleted the bump-formula-pr-write-only-fix branch November 13, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants