-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add brew --taps command
#21058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brew --taps command
#21058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new brew --taps command to display the path to Homebrew's Taps directory, providing a convenient helper similar to existing commands like brew --repository.
Key changes:
- Implements a new
--tapscommand that outputs the Taps directory path - Adds the corresponding Sorbet type signature file for the new command
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/cmd/--taps.rb | Implements the new --taps command following the AbstractCommand pattern with proper type annotations |
| Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/taps.rbi | Auto-generated Sorbet type definitions for the new Taps command class |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/taps.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/taps.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rylan12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Fine to merge as-is for now, but I think this should be a bash command like --repository so it can be nice and fast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/taps.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
05bf748 to
7cb2651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/taps.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Patrick Linnane <[email protected]>
073227f to
6c1e7f4
Compare
brew lgtm(style, typechecking and tests) with your changes locally?This is a small helper like
brew --repositorybecause I often find myself navigating to the Taps folder manually.