Skip to content

Conversation

@p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

This is a small helper like brew --repository because I often find myself navigating to the Taps folder manually.

Copilot AI review requested due to automatic review settings November 14, 2025 01:11
Copilot finished reviewing on behalf of p-linnane November 14, 2025 01:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new brew --taps command to display the path to Homebrew's Taps directory, providing a convenient helper similar to existing commands like brew --repository.

Key changes:

  • Implements a new --taps command that outputs the Taps directory path
  • Adds the corresponding Sorbet type signature file for the new command

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
Library/Homebrew/cmd/--taps.rb Implements the new --taps command following the AbstractCommand pattern with proper type annotations
Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/taps.rbi Auto-generated Sorbet type definitions for the new Taps command class
Files not reviewed (1)
  • Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/taps.rbi: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 14, 2025 01:20
Copilot finished reviewing on behalf of p-linnane November 14, 2025 01:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/taps.rbi: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Fine to merge as-is for now, but I think this should be a bash command like --repository so it can be nice and fast

Copilot AI review requested due to automatic review settings November 14, 2025 04:42
Copilot finished reviewing on behalf of p-linnane November 14, 2025 04:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/taps.rbi: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 14, 2025 08:38
Copilot finished reviewing on behalf of MikeMcQuaid November 14, 2025 08:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/taps.rbi: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Patrick Linnane <[email protected]>
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 14, 2025
Merged via the queue into main with commit a35b323 Nov 14, 2025
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the brew-taps-cmd branch November 14, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants