Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Nov 14, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

This was previously done by install_bundler! before d562e44


I don't know about other places we were running install_bundler! but the removal of this at below (originally line 244) seems to cause issues:

Prior to change, strange errors like

  • if brew Ruby is installed and on PATH, gems link to that one. Need to purge old gems to get brew to work again.
  • brew tries running on system Ruby 2

This was previously done by `install_bundler!` before
d562e44
Copilot AI review requested due to automatic review settings November 14, 2025 01:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the setup_gem_environment! call that was removed in a previous commit (d562e44), ensuring it runs for all invocations of install_bundler_gems!, not just during tests. The change also simplifies the conditional logic by using an early return pattern.

Key Changes:

  • Moved setup_gem_environment! call outside the test-only conditional block
  • Refactored the test environment check to use an early return pattern
  • Ensures gem environment is properly configured before the early return in test mode

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p-linnane p-linnane added this pull request to the merge queue Nov 14, 2025
Merged via the queue into main with commit b12b853 Nov 14, 2025
43 checks passed
@p-linnane p-linnane deleted the setup_gem_environment branch November 14, 2025 05:09
@p-linnane
Copy link
Member

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @cho-m!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants