Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Nov 18, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

Increase arm64 Linux testing to now run on dependents as long as CI-linux-self-hosted-deps is not used.

As far as I can tell, arm64 Linux is faster than Intel Linux so should be able to finish within same time frame.

This should make our arm64 Linux support closer to complete "Tier 1" status. The remainder of CI either needs self-hosted runner or adding support for splitting dependent tests across separate jobs.

Copilot AI review requested due to automatic review settings November 18, 2025 16:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances arm64 Linux testing by enabling it for dependent tests when not using self-hosted runners. Previously, arm64 Linux runners were excluded from all dependent matrix tests, but now they are only excluded when using the self-hosted runner (CI-linux-self-hosted-deps).

  • Modifies the runner generation logic to conditionally include arm64 Linux runners based on whether self-hosted runners are being used
  • Adds test coverage for both scenarios: dependent tests with and without self-hosted runners

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Library/Homebrew/github_runner_matrix.rb Updates logic to only exclude arm64 Linux runner when using self-hosted runners for dependent tests
Library/Homebrew/test/github_runner_matrix_spec.rb Adds test cases verifying arm64 Linux runner is included for non-self-hosted dependent tests and excluded for self-hosted ones

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
Copy link
Member

The remainder of CI either needs self-hosted runner or adding support for splitting dependent tests across separate jobs.

Work continues on self-hosted work.

Splitting dependent tests would be very cool if we could do it, though. Means we could likely use GitHub runners a lot more on both macOS and Linux.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 18, 2025
Merged via the queue into main with commit 65a72d8 Nov 18, 2025
62 of 63 checks passed
@MikeMcQuaid MikeMcQuaid deleted the github_runner_matrix-test-arm64-linux-deps branch November 18, 2025 18:06
@cho-m cho-m mentioned this pull request Nov 19, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants