-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
extend/os/mac/system_config: check for Metal Toolchain #21117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Metal Toolchain detection to brew config output. Starting with Xcode 26, the Metal Toolchain is no longer bundled and must be installed separately. This change helps diagnose issues with formulae that depend on the Metal Toolchain by showing its installation status in the configuration output.
Key Changes:
- Adds a
metal_toolchainmethod that detects Metal Toolchain presence by runningxcrun metal -v - Displays Metal Toolchain status in
brew configoutput when Xcode version is 26.0 or higher - Uses proper Sorbet type signature for the new method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2ce3633 to
7891244
Compare
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
72d62f3 to
dd044ba
Compare
Signed-off-by: Patrick Linnane <[email protected]> Co-authored-by: Copilot <[email protected]>
dd044ba to
95c90b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
brew lgtm(style, typechecking and tests) with your changes locally?Starting with Xcode 26 the Metal Toolchain is no longer bundled. We're starting to see formulae that depend on the presence of the Metal Toolchain. This PR adds a check to
brew configto output if the toolchain is installed to help us verify inevitable reports. If we start identifying enough formulae we may want to adddepends_on :metal_toolchain, but I don't think that's necessary yet.