Skip to content

Conversation

@p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

Starting with Xcode 26 the Metal Toolchain is no longer bundled. We're starting to see formulae that depend on the presence of the Metal Toolchain. This PR adds a check to brew config to output if the toolchain is installed to help us verify inevitable reports. If we start identifying enough formulae we may want to add depends_on :metal_toolchain, but I don't think that's necessary yet.

Copilot AI review requested due to automatic review settings November 20, 2025 23:41
Copilot finished reviewing on behalf of p-linnane November 20, 2025 23:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Metal Toolchain detection to brew config output. Starting with Xcode 26, the Metal Toolchain is no longer bundled and must be installed separately. This change helps diagnose issues with formulae that depend on the Metal Toolchain by showing its installation status in the configuration output.

Key Changes:

  • Adds a metal_toolchain method that detects Metal Toolchain presence by running xcrun metal -v
  • Displays Metal Toolchain status in brew config output when Xcode version is 26.0 or higher
  • Uses proper Sorbet type signature for the new method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 20, 2025 23:55
Copilot finished reviewing on behalf of p-linnane November 20, 2025 23:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p-linnane p-linnane force-pushed the metal-toolchain-config branch from 2ce3633 to 7891244 Compare November 21, 2025 00:02
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

Copilot AI review requested due to automatic review settings November 23, 2025 04:51
Copilot finished reviewing on behalf of p-linnane November 23, 2025 04:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p-linnane p-linnane force-pushed the metal-toolchain-config branch from 72d62f3 to dd044ba Compare November 23, 2025 04:59
Signed-off-by: Patrick Linnane <[email protected]>

Co-authored-by: Copilot <[email protected]>
@p-linnane p-linnane force-pushed the metal-toolchain-config branch from dd044ba to 95c90b3 Compare November 23, 2025 05:17
Copilot AI review requested due to automatic review settings November 23, 2025 05:17
Copilot finished reviewing on behalf of p-linnane November 23, 2025 05:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2025
@p-linnane p-linnane added this pull request to the merge queue Nov 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2025
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit b3c992a Nov 24, 2025
41 checks passed
@MikeMcQuaid MikeMcQuaid deleted the metal-toolchain-config branch November 24, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants