Skip to content

Conversation

@BenMusch
Copy link
Contributor

@BenMusch BenMusch commented Aug 11, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Seems like this method call was missed in https://github.com/Homebrew/brew/pull/2548/files

I got this error earlier:

$ brew search caskroom/cask/jet
Error: undefined method `search_tap' for Homebrew:Module
/usr/local/Homebrew/Library/Homebrew/compat/global.rb:9:in `method_missing'
/usr/local/Homebrew/Library/Homebrew/cmd/search.rb:51:in `rescue in search'
/usr/local/Homebrew/Library/Homebrew/cmd/search.rb:48:in `search'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'

And a google search took me to that PR

Tests coming soon! Done!

@BenMusch
Copy link
Contributor Author

Unrelated, but would it break docs to add a frozen_string_literal: true comment?

@MikeMcQuaid
Copy link
Member

@BenMusch We're still using Ruby 2.0 here so let's skip that for now, thanks.

@MikeMcQuaid
Copy link
Member

Thanks for your first contribution to Homebrew, @BenMusch (particularly fantastic work with the tests)! Without people like you submitting PRs we couldn't run this project. You rock!

@MikeMcQuaid MikeMcQuaid merged commit 7ecc775 into Homebrew:master Aug 12, 2017
@BenMusch BenMusch deleted the search-tap-fix branch August 12, 2017 12:24
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants