Skip to content

Conversation

@ilovezfs
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

superenv and the :ruby requirement make a rake DSL unnecessary.

Fixes #3310.

@ilovezfs ilovezfs requested a review from MikeMcQuaid October 13, 2017 07:41
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an addition to Library/Homebrew/compat/formula.rb or Library/Homebrew/compat/fileutils.rb with system "rake", *args but when that's the case: 👍

superenv and the `:ruby` requirement make a `rake` DSL unnecessary.
@ilovezfs ilovezfs changed the title fileutils: remove rake DSL fileutils: deprecate rake DSL Oct 13, 2017
@MikeMcQuaid
Copy link
Member

:shipit:

@ilovezfs ilovezfs merged commit 64270ed into Homebrew:master Oct 13, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants