formula_desc_cop: Whitelist "etc." and fix the full stop autocorrect #3411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issyl0
force-pushed
the
whitelist_etc_and_fix_autocorrect
branch
from
ddd9f6f to
c21a868
Compare
added 2 commits
November 1, 2017 19:50
- It wasn't working because desc strings end in quotes, not just full stops.
issyl0
force-pushed
the
whitelist_etc_and_fix_autocorrect
branch
from
c21a868 to
5cbb414
Compare
Member
|
Looks good, thanks @issyl0! Would you mind writing some tests to check these work as expected? Thanks again! |
Member
|
@issyl0 Any news on that? If you'd rather not: no worries. |
Member
Author
|
Sorry @MikeMcQuaid, this week has been stupidly busy and I'm unlikely to get time to do this soon. Sorry for leaving this hanging too. Also, from what I can see, the existing tests always test that violations are reported, not that they're ignored, if that makes any sense, and negating that for this one case feels odd. |
MikeMcQuaid
approved these changes
Nov 19, 2017
Member
|
Will merge without tests this time but please write some in future. Thanks @issyl0! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?As per #2795 (comment), here's a PR to whitelist "etc." only in the full stop format_desc_cop, and fix the autocorrect so it works with quotes at the end of the line too. I ran a
brew audit --strictand it stopped complaining about formulae withetc.at the end.