curl: unset SSL_CERT_FILE. #3417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I wouldn't be surprised if we have people relying on being able to set that. |
Member
Author
|
@ilovezfs Fair point. If we break their workflows we may need to figure out a workaround for that (and env filtering isn't looking drastically far off at this point). I think we need to merge something similar to this to workaround the issue with our Ruby. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL_CERT_FILE can be incorrectly set by users or portable-ruby and screw with SSL downloads so unset it here.
CC @ilovezfs for thoughts on the approach